Skip to content

#139 add region_name to create_bucket - #140

Merged
martindurant merged 3 commits into
fsspec:masterfrom
delijati:master
Jul 27, 2018
Merged

#139 add region_name to create_bucket#140
martindurant merged 3 commits into
fsspec:masterfrom
delijati:master

Conversation

@delijati

Copy link
Copy Markdown
Contributor

#139 add region_name to create_bucket

@martindurant

Copy link
Copy Markdown
Member

I think region_name=None should be an optional argument to mkdir, and that the fallback default in this code should only be used as the fallback for the None. What do you think?

@delijati

Copy link
Copy Markdown
Contributor Author

Changed it to this comment boto/boto3#781 (comment)

@delijati

Copy link
Copy Markdown
Contributor Author

btw. is it also possible to copy from user a bucket to a user b bucket, with different permissions?

@martindurant

Copy link
Copy Markdown
Member

Yep, I like that.
Please also add the parameter to the docstring in mkdir. I have no idea why py35, in particular, is failing, but it looks unrelated, perhaps a different version of the boto/moto stack. It would probably be reasonable to not test on py35 any more.

@martindurant

Copy link
Copy Markdown
Member

is it also possible to copy from user a bucket to a user b bucket, with different permissions?

I don't know - I don't see why not.

@delijati

Copy link
Copy Markdown
Contributor Author

is it also possible to copy from user a bucket to a user b bucket, with different permissions?
I don't know - I don't see why not.

it seams only over first copying to local disk :/

https://stackoverflow.com/questions/41939170/copy-ami-from-one-aws-account-to-another-aws-account-using-boto

@martindurant

Copy link
Copy Markdown
Member

OK, going to merge this, and should open an issue to look into the py35 failure.

@martindurant
martindurant merged commit df620c1 into fsspec:master Jul 27, 2018
@martindurant martindurant mentioned this pull request Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants