[Repo Assist] Fix record copy expression indentation when nested in parentheses#3330
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
When a record copy expression (e.g. `{ r with Z = 1 }`) was nested inside
parentheses, the fields were indented to the same column as the copy
expression variable `r`, violating F#'s offside rule and causing a
compiler error.
Root cause: genMultilineRecordCopyExpr used atCurrentColumnIndent to
capture r's column (e.g. 8), then indent() added IndentSize (4) to the
restored outer indent (4) = 8, same as r's column.
Fix: detect when the post-indent level is at or below the copy expression
column and bump it by IndentSize so fields are always strictly to the
right of the copy expression.
Fixes #2529
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Closes #2529
Root Cause
When a record copy expression (e.g.
{ r with Z = 1 }) was nested inside parentheses like:A regression test was added to
AlignedMultilineBracketStyleTests.fscovering the exact scenario from issue #2529.Note: this supersedes the earlier draft PR #3297 which targeted an older base and is now 31 commits behind
main.