[Repo Assist] Regression test for idempotency bug with NUnit Assert.That lambda (#1740)#3232
Merged
nojaf merged 2 commits intoFeb 28, 2026
Conversation
…th lambda) The bug was a non-idempotent format of Assert.Throws with a chained .Message property access. The issue is now fixed in current Fantomas; this test ensures it stays fixed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
Contributor
|
/repo-assist add changelog entry |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Commit pushed:
|
10 tasks
nojaf
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Closes #1740
Summary
Adds a regression test for the idempotency bug reported in #1740, where formatting code like:
...would produce a different result on second formatting (non-idempotent).
Root Cause
The bug involved incorrect indentation of a chained
.Messageproperty access after a multi-line lambda argument toAssert.Throws. The formatter was moving.Messageto an inconsistent position on the second pass.Fix
The bug is already fixed in the current codebase. The formatter now correctly collapses the expression to:
...and this output is stable across multiple formatting passes.
Test Status
✅ New test
idempotency problem when formatting NUnit Assert.That with lambda, 1740passes.✅ No existing tests broken.