docs: correct release process to match deployed Prow config - #324
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Correcting my earlier version of this comment, which had the history backwards. You were right. At the time you opened this, the deployed job genuinely did not match the README. The fslabscli entry in branches = ["^cargo-fslabscli-\\d+\\.\\d+\\.\\d+$"]
tag_pattern = "cargo-fslabscli-.*"with no What changed is that the job got fixed rather than the docs. That landed in infra on 2026-07-28, and the entry now reads: job_name = "publish-release"
branches = ["^v\\d+\\.\\d+\\.\\d+$"]
tag_pattern = "v.*"
tag_format = "v{version}"
draft = {
enabled = true
branches = ["^main$"]
publish_steps = "nix,github"
}So The upshot is that the README section this PR rewrites is now accurate, and merging the rewrite would re-document the behaviour we just removed. My suggestion is to close this as fixed rather than merged. It did its job by surfacing the misconfiguration. One small gap remains if you want to land something here: the README does not name the publish job, which is Two bits of residue worth knowing about:
|
The previous
## Release Processsection described adraft-releasepostsubmit on push tomainproducing av{version}-tagged draft. That job is not deployed. The actual publish trigger in fslabs-infra (modules/ci/prow/terragrunt.hcl) is apublish-allpostsubmit on branches matching^cargo-fslabscli-\d+\.\d+\.\d+$, which runsfslabscli publishand creates the tag ascargo-fslabscli-{version}.This PR rewrites the section (steps + Mermaid diagram) so it matches what actually runs.