fix(script): honour --code-size-limit CLI flag#15170
Merged
Merged
Conversation
`check_contract_sizes()` builds its `size_limits` from `config.code_size_limit` (foundry.toml) only. When a user passes `--code-size-limit` on the CLI, the value lands in `evm_opts.env.code_size_limit` but is never consulted here, so the check silently falls back to EIP-170's 24576-byte default. Without this fix, post-broadcast warnings fire for every factory contract despite the flag being set correctly.
shapeshed
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr and
mattsse
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_contract_sizes()ignored the--code-size-limit CLIflag, falling back to EIP-170's 24576-byte default. This PR fixes the issue it by readingevm_opts.env.code_size_limitbeforeconfig.code_size_limit.Motivation
check_contract_sizes()built itssize_limitssolely fromconfig.code_size_limit(foundry.toml). The--code-size-limitCLI flag populatesevm_opts.env.code_size_limitbut was never read here, so the check silently fell back to EIP-170's 24576-byte default even when the flag was explicitly set.Solution
Chain
.or(evm_opts.env.code_size_limit)before the config lookup so the CLI flag takes precedence over foundry.toml. A test asserts the flag is correctly threaded intoevm_opts(the path the check now reads).PR Checklist