chore: make clippy happy#15169
Closed
0xMars42 wants to merge 1 commit into
Closed
Conversation
The latest nightly clippy flags median_sorted and has_indented_parent_chain as missing_const_for_fn. Make them const to unblock the clippy CI job (cargo clippy --workspace --all-targets --all-features with -Dwarnings).
0xMars42
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr and
mattsse
as code owners
stevencartavia
left a comment
stevencartavia
left a comment
Member
There was a problem hiding this comment.
i already opened a PR for this, thanks
#15168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clippy CI job (
cargo clippy --workspace --all-targets --all-features --lockedwith-Dwarnings, nightly) fails on the current nightly: clippy now flags two functions asmissing_const_for_fn.foundry_common::calc::median_sorted(crates/common/src/calc.rs)State::has_indented_parent_chain(crates/fmt/src/state/mod.rs)Make both
const, as clippy suggests. No behavior change.