fix(fmt): balance override variable indentation#15153
Merged
Merged
Conversation
3 tasks
Co-authored-by: clouds56 <730813+clouds56@users.noreply.github.com>
96717c4 to
9240816
Compare
mablr
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15151.
Summary
overrideattribute when the variable has no initializer.Root Cause
print_varopens an additional box while printingoverrideattributes. The initializer path closes that box before formatting the RHS, but the no-initializer path only closed the regular variable boxes. That left the pretty-printer one indent level deep, so later source-unit items were emitted indented.