Skip to content

ci: add derek bench trigger#15138

Merged
grandizzy merged 5 commits into
foundry-rs:masterfrom
kuyziss:codex/scfuzzbench-pr-trigger
Jun 15, 2026
Merged

ci: add derek bench trigger#15138
grandizzy merged 5 commits into
foundry-rs:masterfrom
kuyziss:codex/scfuzzbench-pr-trigger

Conversation

@kuyziss

@kuyziss kuyziss commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a PR comment trigger that publishes a signed benchmark event to internal
infra over mTLS. Command is derek bench <subcommand> (also decofe bench /
@decofe bench); only invariant is live today, build/all are reserved.
The benchmark runs server-side and reports results separately.

Changes

  • derek bench invariant [args] trigger (subcommand namespace; build/all reserved)
  • Move authorization into the job-level if; drop unused permission
  • Add per-PR concurrency
  • Pass secrets via quoted env vars (not inline) and scope them to a shared
    bench environment
  • Send a minimal payload with only the user-tunable knobs
    (compare-ref, timeout, workers, benchmark-type); everything else comes from
    server defaults
  • Reject forks; re-validated server-side

Usage

derek bench invariant                                   # all defaults
derek bench invariant timeout=300 workers=2             # short test run
derek bench invariant compare-ref=v1.0.0 timeout=7200 workers=16 benchmark-type=optimization

Knobs: compare-ref (default master), timeout (60-14400s, default 3600),
workers (1-256, default = server), benchmark-type (property|optimization,
default property).

@kuyziss kuyziss force-pushed the codex/scfuzzbench-pr-trigger branch from c1d1c65 to c6b2517 Compare June 11, 2026 13:30
@kuyziss kuyziss marked this pull request as ready for review June 11, 2026 13:53

@mablr mablr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm, just a small question.

Comment thread .github/workflows/scfuzzbench.yml Outdated
- New bench.yml replaces the scfuzzbench trigger; command is
  `derek bench invariant [args]` (subcommand namespace; build/all reserved)
- Move authorization into the job-level if; drop unused permission
- Add per-PR concurrency
- Pass secrets via quoted env vars (not inline) and scope them to a shared
  `bench` environment
- Send a minimal payload with only the user-tunable knobs
  (compare-ref, timeout, workers, benchmark-type)
@grandizzy grandizzy changed the title [codex] Add scfuzzbench PR trigger ci: add derek bench trigger Jun 15, 2026
@grandizzy grandizzy requested a review from mablr June 15, 2026 07:26
Comment thread .github/workflows/bench.yml
Comment thread .github/workflows/bench.yml
@grandizzy grandizzy requested a review from mablr June 15, 2026 08:03

@mablr mablr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@grandizzy grandizzy enabled auto-merge (squash) June 15, 2026 08:18
@grandizzy grandizzy merged commit 9dcc743 into foundry-rs:master Jun 15, 2026
19 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Foundry Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants