Skip to content

feat(tempo): show resolved fee token + clean-ups#15130

Merged
mablr merged 5 commits into
masterfrom
mablr/visible-fee-token-defaults
Jun 11, 2026
Merged

feat(tempo): show resolved fee token + clean-ups#15130
mablr merged 5 commits into
masterfrom
mablr/visible-fee-token-defaults

Conversation

@mablr

@mablr mablr commented Jun 10, 2026

Copy link
Copy Markdown
Member

Motivation

Materialize Tempo default fee tokens in cast transaction building and print the resolved fee token before sending, signing, or emitting transactions across cast, forge create, and script broadcast paths.

Add no-RPC labels for well-known Tempo fee tokens and centralize the local AlphaUSD, BetaUSD, and ThetaUSD addresses for reuse in EVM core and Anvil.

Towards OSS-165

Materialize Tempo default fee tokens in cast transaction building and print the resolved fee token before sending, signing, or emitting transactions across cast, forge create, and script broadcast paths.

Add no-RPC labels for well-known Tempo fee tokens and centralize the local AlphaUSD, BetaUSD, and ThetaUSD addresses for reuse in EVM core and Anvil.
stevencartavia
stevencartavia previously approved these changes Jun 11, 2026

@grandizzy grandizzy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall — couple of things to check.

Comment thread crates/cast/src/tx.rs Outdated
Comment thread crates/evm/core/src/tempo.rs Outdated
@0xKarl98

Copy link
Copy Markdown
Contributor

Have nothing to against it except for which have been proposed by @grandizzy

Comment thread crates/cast/src/cmd/mktx.rs Outdated
figtracer
figtracer previously approved these changes Jun 11, 2026

@figtracer figtracer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grandizzy grandizzy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues with the fee-token display:

  1. The main send paths (cast send / mktx / batch-mktx / tip20 / keychain) never show the default fee token, because it isn't materialized: tx.fee_token() is None unless the user passed --tempo.fee-token, so print_fee_token_selection is a no-op on the default path. This defeats the PR's goal of showing the resolved token before sending.

  2. cast vaddr create materializes the default into the request (and the pre-existing paths in cast erc20 / forge create do the same). Setting fee_token = PathUSD is not wire-neutral and overrides the node's on-chain fee-token preference — the same concern raised above on tx.rs.

Recommend a single display-only resolver used by all paths, and removing the set_fee_token materializations.

Comment thread crates/cast/src/cmd/send.rs Outdated
Comment thread crates/cast/src/cmd/vaddr/create.rs Outdated
Comment thread crates/common/src/tempo/mod.rs
@grandizzy grandizzy self-requested a review June 11, 2026 09:17
@mablr mablr requested review from figtracer and grandizzy June 11, 2026 09:25
@mablr mablr enabled auto-merge (squash) June 11, 2026 09:25
@mablr mablr merged commit da072b8 into master Jun 11, 2026
19 checks passed
@mablr mablr deleted the mablr/visible-fee-token-defaults branch June 11, 2026 09:26
@github-project-automation github-project-automation Bot moved this to Done in Foundry Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants