feat(cast): support Tempo sessions in transaction commands#15096
Merged
Conversation
0xKarl98
requested review from
0xrusowsky,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards oss-162
Adds shared Tempo helpers for resolving an explicit session before falling back to wallet signer resolution, and applies them to:
cast batch-mktxcast erc20cast tip20 createcast tip20 mine --registercast vaddr createAlso rejects unsupported session combinations such as
--browser,--ethsign, and--raw-unsignedwhere applicable,validates sessions against the active chain, and fills access-key transaction metadata before signing transactions built outside
CastTxBuilder.Additionally,
batch-mktx --raw-unsignednow preserves Tempo access-key metadata while set signer to None.