refactor(script): isolate Tempo session signer handling#15089
Merged
Conversation
0xKarl98
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr and
mattsse
as code owners
0xKarl98
changed the title
stevencartavia
previously approved these changes
Jun 6, 2026
mablr
previously approved these changes
Jun 6, 2026
mablr
previously requested changes
Jun 6, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
Lgtm, just a smol nit on test :)
| ); | ||
|
|
||
| let for_command = format!( | ||
| "{} script {} --tc SessionForgeScript --broadcast --rpc-url {} --root {}", |
Member
There was a problem hiding this comment.
wallet_session_run_for_forge_script_submits_with_session_key reaches timeout (90s).
The test only needs to prove the session key path submits and writes a broadcast hash, so using the full forge script default timeout (120s) is unnecessary. Setting explicitly a lower timeout should fix this test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards OSS-162 ,
Extract the Forge script Tempo session signer policy into
script::session, including:(chain, sender)broadcast.rsnow uses this module when preparing raw signer maps, andbuild.rsuses the same scope model when checking whether a resumed script has all required signers available.Also adds a CLI regression test for
cast wallet session --for "<forge> script ... --broadcast"and updates the test utility helper that builds sibling Foundry binaries so it preserves the current Cargo target directory and profile.