feat(config): enable dynamic-test-linking by default#14718
Merged
Conversation
mablr
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mattsse,
stevencartavia and
zerosnacks
as code owners
Base automatically changed from
mablr/fix-salted-create2-script-preprocessor
to
master
May 13, 2026 09:14
mablr
force-pushed
the
mablr/default_dynamic_test_linking
branch
from
1a46c28 to
e45e791
Compare
This comment was marked as low quality.
This comment was marked as low quality.
mablr
commented
Jun 4, 2026
Member
Author
There was a problem hiding this comment.
Benchmarks for 4ebcdad
| Project | Mutation | dynamic_test_linking = false (initial rebuild/ rebuild) |
dynamic_test_linking = true (initial rebuild/ rebuild) |
|---|---|---|---|
| Solady | duplicate _setOwner(newOwner); |
12.52s / 1.48s | 12.62s / 1.52s |
| Uniswap v4-core | add Lock.lock(); |
109.54s / 96.76s | 48.31s / 11.63s |
| Morpho Blue | duplicate require(assets != 0, ErrorsLib.ZERO_ASSETS); |
162.68s / 162.83s | 134.61s / 52.46s |
| Aave v4 | add require(assetId < _assetCount, AssetNotListed()); |
197.79s / 184.19s | 201.41s / 185.27s |
Member
|
figtracer
approved these changes
Jun 8, 2026
mattsse
approved these changes
Jun 8, 2026
grandizzy
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #10285, by enabling
dynamic-test-linkingby default