fix(anvil): handle zero prune history safely#14307
Merged
figtracer merged 9 commits intoJun 8, 2026
Merged
Conversation
mk0walsk
requested review from
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mk0walsk
requested review from
0xrusowsky,
figtracer,
mablr and
stevencartavia
as code owners
Contributor
Author
|
@mablr Done, please take another look, thanks! |
mablr
reviewed
Apr 14, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
smol pedantic nit :)
otherwise it's good.
mablr
previously approved these changes
Apr 16, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
sgtm, pending another review ...
figtracer
reviewed
Apr 16, 2026
Contributor
|
This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days if there is no further activity. |
figtracer
approved these changes
Jun 8, 2026
mablr
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--prune-history 0currently reaches the in-memory history cache as0.InMemoryBlockStates::enforce_limits()then loops onwhile self.present.len() >= self.in_memory_limit, which can hang block production when the limit is zero.Solution
Normalize
max_memory_history == 0to the unsupported path inPruneStateHistoryConfig, and defensively clamp in-memory cache limits to at least1insideInMemoryBlockStates. Add regression tests for the config normalization and zero-limit cache guard.PR Checklist