Add CS and update to upstream 1.2.6#8
Conversation
|
Thanks, looks good. I can also add you as an admin if you wish. cc @j0k3r |
|
Won't this be hard to keep the projet update with the upstream if we apply PHP-CS-Fixer? |
|
Updating should not be a problem – just overwrite the code with fresh upstream one, run php-cs-fixer, and then re-apply our patches that have not been upstreamed yet. Pushing changes upstream will be harder. Perhaps we could try to convince upstream to use code formatting to make that easier? |
|
I manually applied changes shown by a simple diff against archives from sourceforge ( |
|
... and fixing things (outside of upstream patches) is quite horrible without some CS |
|
@jtojnar fine for me for the admin permission :) |
|
@Kdecherf maybe you can add a GitHub workflow to check CS for PR? |
|
@j0k3r I've added a workflow but it seems that it will run only after being merged in master |
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
No description provided.