Skip to content

Add testcase for srcset attribute in source tag#15

Merged
Kdecherf merged 1 commit intofossar:masterfrom
Kdecherf:impr/source-srcset
Jul 22, 2023
Merged

Add testcase for srcset attribute in source tag#15
Kdecherf merged 1 commit intofossar:masterfrom
Kdecherf:impr/source-srcset

Conversation

@Kdecherf
Copy link

@Kdecherf Kdecherf commented May 23, 2023

Fixes wallabag/wallabag#6365

This PR is based on #14

@Kdecherf Kdecherf requested review from j0k3r and jtojnar May 23, 2023 21:36
@jtojnar
Copy link
Member

jtojnar commented May 23, 2023

Weird, this was supposed to be fixed in 1.2.12: http://www.bioinformatics.org/phplabware/forum/viewtopic.php?pid=1006#p1006 Never mind, that was sizes.

@jtojnar
Copy link
Member

jtojnar commented May 23, 2023

Reported upstream: http://www.bioinformatics.org/phplabware/forum/viewtopic.php?pid=1014

@Kdecherf
Copy link
Author

@jtojnar do you want to wait for an upstream update?

@jtojnar
Copy link
Member

jtojnar commented May 24, 2023

Either way sounds good to me. I will leave it up to you.

@j0k3r
Copy link

j0k3r commented May 24, 2023

Could you rebase against the master to remove the extra first commit?

@Kdecherf Kdecherf force-pushed the impr/source-srcset branch from 7d9aaee to 0601e8a Compare May 24, 2023 11:56
@Kdecherf
Copy link
Author

@j0k3r done

@Kdecherf Kdecherf force-pushed the impr/source-srcset branch from 0601e8a to 6e3d0f7 Compare July 22, 2023 16:11
@Kdecherf
Copy link
Author

I've rebased this PR on #16, keeping just a new testcase

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf Kdecherf force-pushed the impr/source-srcset branch from 6e3d0f7 to 2ea2167 Compare July 22, 2023 16:31
@Kdecherf Kdecherf requested a review from j0k3r July 22, 2023 16:31
@Kdecherf Kdecherf changed the title Allow srcset attribute in source tag Add testcase for srcset attribute in source tag Jul 22, 2023
@Kdecherf Kdecherf merged commit 2975518 into fossar:master Jul 22, 2023
@Kdecherf Kdecherf deleted the impr/source-srcset branch July 22, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image not loaded from medium

3 participants