Merged
Conversation
I give up on keeping code style Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
It's hard to keep up with upstream when having different coding styles Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
|
But the CS is still applied to the changes of the PR. You only removed the GitHub Actions not your changes. |
Author
Why are you thinking that the mentioned commits weren't applied in this PR? |
Author
|
For example, changes from 36fd540 are there: https://github.com/fossar/HTMLawed/pull/13/files#diff-de6a7cbbecb3f5429086abe7dac1ffd2e5bf4a084f5a6acda3e841d00a5c4022R1200-R1207 |
|
I can't remember why I said that.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I give up on keeping coding style because the original author refactored his file several times since our last upstream update and it's way to hard to keep our cs-fixer happy with it.
For this PR I took the
htmLawed.phpfrom the version 1.2.11 and manually applied back the following commits from our history: