Skip to content

Allow phrasing content (#pcdata) inside ruby tags#1

Merged
j0k3r merged 1 commit intofossar:masterfrom
Kdecherf:master
Dec 14, 2018
Merged

Allow phrasing content (#pcdata) inside ruby tags#1
j0k3r merged 1 commit intofossar:masterfrom
Kdecherf:master

Conversation

@Kdecherf
Copy link

Fixes wallabag/wallabag#3710

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@techexo
Copy link

techexo commented Dec 10, 2018

To support this pull request, the reference of HTML5 regarding ruby contains multiple examples where the ruby element contains data.

@jtojnar
Copy link
Member

jtojnar commented Dec 11, 2018

Thank you but this is only a mirror – any contributions should go upstream, sent by e-mail according to http://www.bioinformatics.org/phplabware/forum/viewtopic.php?id=133. Though the only e-mail address I was able to find was a PayPal username.

@j0k3r
Copy link

j0k3r commented Dec 11, 2018

@jtojnar I agree it's only a mirror.

But getting that fix merged upstream seems to be really complex:

  1. sending the code by email,
  2. (eventually) getting a reply from the author,
  3. fix provided upstream,
  4. a new release, and
  5. finally that repo updated with the latest release 🤕

Can't we accept PR on this repo and merge upstream from time to time when a release is done?

Otherwise, we should disable PR and issues for that repo and update the readme to explicitely explain why this repo exists and why we didn't accept contributions.

Also, if we finally choose not to approve contributions, my guess is that we (wallabag) are going to fork this repo to apply our own contributions 🤷‍♂️

@jtojnar
Copy link
Member

jtojnar commented Dec 11, 2018

If you want to do this, I don't object. I just do not have the time to maintain this apart from pulling the new versions.

@j0k3r
Copy link

j0k3r commented Dec 14, 2018

Ok I agree too.
We are not going to overtake the upstream just an easier way to push fixes instead of sending an email.

@j0k3r j0k3r merged commit f7a324a into fossar:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants