Skip to content

Support Node.js ES Modules #6

Open

Description

@adamhenson

Node.js now supports ES Modules. We should support it by exporting both CommonJS and ES modules as outlined in this article and this one.

I attempted this and got pretty far until I reached a blocker in which you need to explicitly define file extensions in the Node.js implementation as described in this issue (see below).

Allowed

import myModule from './myModule.js'

Not allowed

import myModule from './myModule'

Once this issue is addressed in Node.js, we can proceed with this support.

Activity

  1. jacogr commented on Dec 16, 2020

    @jacogr

    Sorry for barging in... :)

    So for the file extensions, since you use babel, I found this plugin useful - https://www.npmjs.com/package/babel-plugin-module-extension-resolver

    (Not affiliated, not the author, just a user to solve the same file-extension madness in https://github.com/polkadot-js/dev/blob/master/packages/dev/config/babel-plugins.cjs#L26)

  2. adamhenson commented on Dec 16, 2020

    @adamhenson
    CollaboratorAuthor

    @jacogr - thanks for the feedback. This issue is about removing the dependency of Babel to ES modules on Node.js natively. Everything works correctly in its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions