Skip to content

Fix causal footer and gutter posture - #204

Open
flyingrobots wants to merge 3 commits into
mainfrom
dogfood/causal-footer-posture
Open

Fix causal footer and gutter posture#204
flyingrobots wants to merge 3 commits into
mainfrom
dogfood/causal-footer-posture

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Summary

  • make footer posture report observed causal ticks instead of mixing historical observation with live head ticks
  • order opened-buffer durability as pending intent, checkpoint/export, Echo receipt, then local dirty projection
  • restore muted gutter line-number hierarchy and harden light/generated companion theme contrast

Verification

  • npm run check

Notes

Follow-up to the dogfooding issues raised around causal footer posture, gutter theming, and unreadable light-theme text.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bb11d29f-aece-44d9-ba11-758d9e8dec66

📥 Commits

Reviewing files that changed from the base of the PR and between e93b2e1 and 223579c.

⛔ Files ignored due to path filters (2)
  • docs/topics/ui/editor-chrome.svg is excluded by !**/*.svg
  • docs/topics/ui/overview.svg is excluded by !**/*.svg
📒 Files selected for processing (18)
  • docs/design/0147-unmaterialized-file-frontier.md
  • docs/topics/ui/README.md
  • docs/topics/ui/editor-chrome.md
  • spec/source-viewer.spec.mjs
  • spec/theme-switch.spec.mjs
  • spec/workspace-app-echo-cutover.spec.mjs
  • spec/workspace-command-line.spec.mjs
  • spec/workspace-footer.spec.mjs
  • spec/workspace-text-boundaries.spec.mjs
  • spec/workspace-worldline-ux.spec.mjs
  • src/app/workspace/workspace-footer-posture.ts
  • src/app/workspace/worldline-graph.ts
  • src/app/workspace/worldline-phase-view.ts
  • src/app/workspace/worldline-tick-span.ts
  • src/ui/jedit-theme-palettes.ts
  • src/ui/jedit-themes.ts
  • src/ui/source-viewer.ts
  • src/ui/workspace-footer-surface-utils.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 223579c18a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const BASIS_CELL_WIDTH = 14;
const HEAD_CELL_WIDTH = 5;
const DELTA_CELL_WIDTH = 9;
const SPAN_CELL_WIDTH = 9;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Widen the span column to preserve tick ranges

When a node has different basis/head ticks, workspaceWorldlineTickSpanLabel(node) can return labels like ticks:t0->t10 (13 characters), but this new column is capped at 9 characters and cell(row.span, SPAN_CELL_WIDTH) truncates it before the drawer is fit to the terminal. In any history with a multi-digit canonical tick or a braid spanning from an older basis to a later head, the phase drawer drops the head tick from the causal span, making the displayed posture inaccurate even on wide terminals.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant