Host bounded workspace observations - #706
Conversation
|
@coderabbitai review |
|
@codex please review |
✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughEcho now admits compiler-produced external-action IR and runs bounded, capability-rooted workspace observations with strict path, basis, budget, settlement, recovery, and replay validation. Supporting fixtures, tests, documentation, dependencies, and generated digests were updated. ChangesBounded workspace external action
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/warp-core/src/external_action_adapter.rs`:
- Around line 623-638: In the candidate construction flow, compute schema
admission evidence from result before constructing
ExternalActionSettlementCandidateV1, then move result directly into new instead
of cloning it. Update the ordering around schema_admission_evidence while
preserving all existing fields and budget validation.
- Around line 566-592: Remove the unused detail parameter from
refused_candidate_with_evidence and delete the let _ = detail statement. Update
the stale-basis call site and any other callers to match the new signature,
while preserving detail folding in refused_candidate before it delegates.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2cee58ac-7427-44cc-973f-f08c9bc32bdb
⛔ Files ignored due to path filters (7)
Cargo.lockis excluded by!**/*.lockcrates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/evidence/provenance.provider-generation.jsonis excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/evidence/review.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/generated/v1/evidence/provenance.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/generated/v1/evidence/review.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/package/v1/generated/evidence/provenance.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/package/v1/generated/evidence/review.provider-generation.jsonis excluded by!**/generated/**
📒 Files selected for processing (22)
CHANGELOG.mdcrates/echo-wesley-gen/assets/v1/edict-provider/package/v1/provider-manifest.echo.jsoncrates/echo-wesley-gen/assets/v1/repository/Cargo.lock.sourcecrates/echo-wesley-gen/tests/provider_package.rscrates/echo-wesley-gen/tests/provider_package_corpus.rscrates/warp-core/Cargo.tomlcrates/warp-core/src/external_action_adapter.rscrates/warp-core/src/lib.rscrates/warp-core/tests/bounded_workspace_observation_tests.rscrates/warp-core/tests/fixtures/external_action/SOURCE.mdcrates/warp-core/tests/fixtures/external_action/observe-workspace.core.cborcrates/warp-core/tests/fixtures/external_action/observe-workspace.core.sha256crates/warp-core/tests/fixtures/external_action/observe-workspace.target-ir.cborcrates/warp-core/tests/fixtures/external_action/observe-workspace.target-ir.sha256docs/README.mddocs/adr/0026-durable-external-action-settlement.mddocs/architecture/application-contract-hosting.mddocs/topics/ExternalActions.mddocs/topics/README.mddocs/topics/RuntimeAuthority.mddocs/topics/WAL.mdschemas/edict-provider/package/v1/provider-manifest.echo.json
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e544b1157
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Merge gate OPEN at 6a132e7.
|
1 participant
Admit compiler-authored workspace observation requests through durable, capability-rooted external-action settlement. Closes #705.
Summary by CodeRabbit
New Features
Documentation
Tests