Preserve typed executable-operation obstructions - #697
Conversation
|
@coderabbitai review |
|
@codex please review |
✅ Action performedReview finished.
|
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe executable-operation pipeline now preserves an authored obstruction coordinate from Core IR through package encoding, independent verification, admission, and duplicate reporting. Package schemas, fixtures, generated artifacts, digests, recovery ordering, and documentation were updated accordingly. ChangesTyped obstruction identity
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35b64a525f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "intrinsic_profile_identity", | ||
| "obstruction_schema_identity", | ||
| "obstruction_interpretation_identity", | ||
| "obstruction_coordinate", |
There was a problem hiding this comment.
Keep v1 packages readable during WAL recovery
When a host upgrades with a WAL containing an installation written by the previous runtime, its embedded echo.operation-package/v1 bytes have no obstruction_coordinate; making that field mandatory in exact_text_map causes recover_installation_v1 to fail when it re-admits those bytes, preventing the durable host from recovering at all. Preserve the old v1 layout through a deterministic migration/default or introduce a versioned package format rather than invalidating already retained installation evidence.
AGENTS.md reference: AGENTS.md:L13-L18
Useful? React with 👍 / 👎.
| lawpack obstruction coordinate resolved from the authored source-local import; | ||
| the scheduler reports that exact typed coordinate without interpreting | ||
| application vocabulary. |
There was a problem hiding this comment.
Describe the coordinate as package-bound, not scheduler-reported
For consumers of TrustedRuntimeHost::echo_operation_action_outcome_v1, an EchoOperationActionOutcomeV1::Obstructed value exposes only the generic obstruction kind and package/installation identities; the scheduler outcome has no obstruction-coordinate field or accessor. The xtask witness obtains the displayed coordinate separately by parsing the package and substituting it after observing PreconditionMismatch, so this current-state claim overstates the runtime API; either propagate the coordinate into the typed outcome or describe it as indirectly bound by the package.
AGENTS.md reference: AGENTS.md:L144-L150
Useful? React with 👍 / 👎.
Preserves lawpack-qualified obstruction coordinates from Edict Core through independent verification and scheduler outcomes. Refreshes checked provider artifacts and the real compiler/runtime witness.
Closes #696.
Summary by CodeRabbit
New Features
causal.cell@1.AlreadyExists, instead of a generic mismatch.Bug Fixes
Documentation