Prove Edict provider conformance and semantic parity by flyingrobots · Pull Request #677 · flyingrobots/echo

flyingrobots · 2026-07-17T11:15:50Z

Closes #657

Outcome

This closes the Edict-to-Echo provider walking-skeleton handoff with one bounded,
reviewed conformance fixture.

The checked provider closure now proves that:

the packaged external lowerer produces the same canonical Target IR bytes and
domain-framed digest as the built-in compatibility path;
the external and built-in paths produce the same semantic bundle identity
while retaining distinct release identities;
the generated helper binds the exact Target IR, semantic bundle, release
bundle, schema, profile, codec, obstruction, and operation propositions;
a capability-denied host executes the packaged lowerer and verifier without
ambient filesystem, environment, registry, process, clock, randomness, or
network authority;
exactly twelve admitted conformance obligations map one-to-one to reviewed
typed executors;
six obligations are host-owned and six are package-owned;
their required dispositions are exactly one accepted, nine rejected, and two
refused; and
independent processes reproduce the completed lowerer, verifier, and package
observations exactly.

The conformance corpus remains declarative. It states obligations; it is not its
own execution evidence, an Echo runtime receipt, or runtime authority.

Plain-English architecture walkthrough

The fixture starts from one exact reviewed Edict source occurrence and
canonicalization profile pinned to Edict revision
c75c3f550d049485ba00eae0dc272c6dd6aca11f.
Echo generation admits the exact checked Edict contract pack and emits the
canonical lawpack, target profile, source-partitioned authority facts,
provider schema, generated-artifact profile, declared resources, provenance,
and non-authoritative review projection.
The built-in compatibility path and the packaged external lowerer consume the
same canonical Core proposition. The external path is not permitted to
rediscover source meaning or consult ambient state.
The packaged lowerer emits canonical echo.span-ir/v1. Its bytes and
domain-framed identity must equal the built-in path exactly.
Echo's verifier independently admits the Core, Target IR, semantic resources,
and requested report roles. Unsupported semantics and unsupported output
claims remain typed refusals; disagreement with a supported proposition is a
rejection.
Package assembly binds the exact checked artifacts, schemas, component bytes,
routes, and release identities. Equal semantics do not imply equal release
identity: the external component coordinates and digests intentionally move
the external release proposition.
The generated helper independently binds the exact Target IR and both bundle
identities. Stale helper pins, altered exact source occurrence, changed
artifact bytes, changed schemas, and changed component bytes all fail closed
at their owning crossing.
A closed parser maps each admitted declaration to exactly one typed executor.
Aggregate host and package dispatch prove that every declared contract ran
exactly once and that no executor silently crossed ownership boundaries.
Deterministic hostile components prove that ambient capability requests and
noncanonical output are denied. Semantic witnesses prove wrong intrinsics,
dropped obstruction arms, unsupported semantics, and output overclaim are
rejected or refused at the correct boundary.
None of this installs a provider into Echo, grants runtime authority,
schedules or executes an application intent, commits causal history, emits
an observation, or produces an Echo runtime receipt. Those are separate
Echo-owned crossings tracked by Echo 1.0: Edict Native Invocation in Echo #583, Gate C - Native Jedit-on-Edict Execution #589, and JS/WASM/Browser Client Release Surface #516.

Exact declarative corpus

Package-owned obligations:

package-parity
artifact-tamper
schema-tamper
component-tamper
helper-identity-mismatch
source-occurrence-change

Host-owned obligations:

ambient-capability-denial
noncanonical-output
unsupported-semantics
output-overclaim
wrong-intrinsic
dropped-obstruction

Every case carries only its crossing, stimulus, and required disposition/contract.
Executor ownership and test results remain outside the canonical declaration.

Exact checked occurrence

Echo PR head at publication: 47d0d8590bffe0180b987f6ee1d58e5a8611c65f
Edict revision:
c75c3f550d049485ba00eae0dc272c6dd6aca11f
Wesley dependency: wesley-core = 0.3.0-alpha.1
Wesley crates.io checksum:
77ca44ae03bac1966eaa6d7660621160f10d3e6979bac26f5929a25a3829c1f4
Wesley release VCS provenance:
280d3d7b1abbaf40dbf5663ab3c5c1d6e58abbed
Provider coordinate: echo.edict-provider@1
Provider package digest:
sha256:fc00dd73a26bbd6699668ddb3ba1e3db9beb9bd7655e270824019d1e6e33f712
Raw provider-manifest SHA-256:
f45d5ea0f504045a4fa8ac4d8f1dcb5e7d6b4c5fca1b3ddd54dca994532ea7c8
Raw conformance-corpus SHA-256:
f1f29d990f83c5af33952a69b16e9c9bbb7c2feb1d3989860b74c9e6c2c19b08
Target IR domain-framed digest:
sha256:d4689abc5c2275ea9c7e1b743197a0d8b4625091632e8f5162eba9ff88d568ad
Semantic bundle digest:
sha256:d3b9170373dc30369b1c7d3435f8c3d2183de063dc9e3b18d4b1f41eeac334c9
Built-in release digest:
sha256:b0d837087d35d131d780819f81c2f327e30987fa95d3c8c3991836b3f9d306e8
External release digest:
sha256:c39449495281b51f978468d08c21e93bcfa423176063b41675da61e4674b0066
Lowerer component: 189,668 bytes,
sha256:f2063b66798fbb1c2b27c3af56e4b78184ffc22c9ed9c7a32c483d05b8c1d382
Verifier component: 189,922 bytes,
sha256:632cc5134861c0b31ccc9ca77d4a09fe757094964369d057b62ca6ba6ad38ad7

Two separately provisioned immutable linux/amd64 Rust 1.90.0 builders
reproduced each component byte-for-byte before the final promotion and package
publication.

The completed package observation is:

target-ir=sha256:d4689abc5c2275ea9c7e1b743197a0d8b4625091632e8f5162eba9ff88d568ad;semantic-bundle=sha256:d3b9170373dc30369b1c7d3435f8c3d2183de063dc9e3b18d4b1f41eeac334c9;builtin-release=sha256:b0d837087d35d131d780819f81c2f327e30987fa95d3c8c3991836b3f9d306e8;external-release=sha256:c39449495281b51f978468d08c21e93bcfa423176063b41675da61e4674b0066;lowerer=echo.dpo.lowerer/component@1#sha256:f2063b66798fbb1c2b27c3af56e4b78184ffc22c9ed9c7a32c483d05b8c1d382;verifier=echo.dpo.verifier/component@1#sha256:632cc5134861c0b31ccc9ca77d4a09fe757094964369d057b62ca6ba6ad38ad7;verifier-outcome=accepted;helper-bound=true

This is a deterministic bounded test observation, not a formal provider receipt
and not an Echo runtime receipt.

RED / GREEN evidence

Focused tests were introduced as RED witnesses before the smallest corresponding
GREEN implementation. Representative witnesses were:

cargo +1.94.0 test \
  --manifest-path tests/edict-provider-host-v1/Cargo.toml \
  --locked --test package_contract

cargo +1.94.0 test \
  --manifest-path tests/edict-provider-host-v1/Cargo.toml \
  --locked --test host_contract

cargo +1.94.0 test \
  --manifest-path tests/edict-provider-host-v1/Cargo.toml \
  --locked --test generated_helper_contract

cargo +1.94.0 test \
  --manifest-path tests/edict-provider-host-v1/Cargo.toml \
  --locked --test conformance_contract

cargo +1.90.0 test -p echo-edict-provider-lowerer --all-targets
cargo +1.90.0 test -p echo-edict-provider-verifier --all-targets
cargo +1.90.0 test -p echo-wesley-gen --test provider_primary_artifacts
cargo +1.90.0 test -p echo-wesley-gen --test provider_package_corpus

Those REDs established the missing parity execution, semantic/release bundle
binding, generated-helper binding, independent-process replay, closed
declaration-to-executor registry, aggregate exact-set dispatch, typed hostile
host behavior, package material tamper laws, source-occurrence release movement,
and the complete twelve-case publication closure.

The completed GREEN branch gate included:

cargo +1.90.0 fmt --all -- --check
cargo +1.90.0 test -p echo-edict-provider-lowerer --all-targets
cargo +1.90.0 test -p echo-edict-provider-verifier --all-targets
cargo +1.90.0 test -p echo-wesley-gen --all-targets

cargo +1.90.0 clippy \
  -p echo-edict-provider-lowerer \
  -p echo-edict-provider-verifier \
  -p echo-wesley-gen \
  --lib --tests -- -D warnings -D missing-docs

scripts/verify-edict-provider-host-v1.sh

cargo +1.90.0 run --locked -p echo-wesley-gen \
  --bin echo-edict-provider-artifacts -- --check

cargo +1.90.0 run --locked -p echo-wesley-gen \
  --bin echo-edict-provider-package -- --check

cargo +1.90.0 run --locked -p echo-wesley-gen \
  --bin echo-edict-provider-assets -- \
  --check-package-list --sync-component-resources

git diff --check
cargo +1.90.0 xtask pr-preflight --full

cargo xtask verify is not a command in this checkout.
cargo +1.90.0 xtask pr-preflight --full is the repository-defined final branch
gate and passed all seven checks. The provider wrapper now runs the exact
conformance_contract declaration/parser suite in CI as well as the host,
helper, package, resource-sync, component-audit, formatting, and strict Clippy
witnesses.

Reproduction commands

From the repository root:

cargo +1.90.0 run --locked -p echo-wesley-gen \
  --bin echo-edict-provider-artifacts --

cargo +1.90.0 run --locked -p echo-wesley-gen \
  --bin echo-edict-provider-package --

scripts/verify-edict-provider-host-v1.sh

Exact component designated-build and two-candidate comparison commands are
checked in under .github/workflows/det-gates.yml; local check/audit/promotion
commands and the immutable linux/amd64 builder identity are documented under
schemas/edict-provider/components/v1/README.md.

Dependency rationale

This adds no new production runtime dependency.

Echo remains pinned to the published wesley-core = 0.3.0-alpha.1 crate,
rather than a sibling path or moving Git dependency. The lockfile pins its
crates.io checksum; the crate's published VCS metadata names the exact Wesley
release commit separately.
Native provider preflight remains pinned to exact Edict revision
c75c3f550d049485ba00eae0dc272c6dd6aca11f.
The isolated unpublished host witness adds exact dev-dependency
wat = 1.251.0 solely to construct a deterministic hostile component for the
noncanonical-output denial case.
The checked component bytes remain the only executable provider components in
the package; no runtime dependency lookup or ambient discovery is introduced.

Documentation impact

Current documentation and release notes now describe:

the complete twelve-obligation corpus and its six-host/six-package ownership;
the exact accepted/rejected/refused split;
built-in versus external semantic and release identity;
exact component and package identities;
declaration, execution-evidence, provider-authority-fact, and Echo
runtime-authority separation;
package, helper, lowerer, verifier, and deterministic-replay boundaries; and
the fact that native Echo installation/execution remains future work.

The direct updates are in CHANGELOG.md, the lowerer and verifier crate READMEs,
docs/architecture/application-contract-hosting.md,
schemas/edict-provider/README.md, and
schemas/edict-provider/components/v1/README.md.

The repository's pre-PR documentation accuracy gate was rerun immediately before
publication and found no stale current-state or ownership claims.

Compatibility notes

No Echo runtime installation or invocation API is added or changed.
The provider CDDL, primary artifacts, authority facts, components, package,
manifest, conformance corpus, semantic resources, and release identities move
to this exact checked occurrence. Consumers of exact pins must update.
Canonical semantic identity remains distinct from exact source occurrence and
release identity.
The external and built-in semantic bundle digests must match; their release
digests are intentionally distinct.
Rejected and refused remain different outcomes. Unsupported semantics or
unsupported output roles do not become fabricated authoritative artifacts.
Authority-facts documents remain provider-semantic claims, not Echo runtime
authority.
Mutating operations may lower through Span/DPO semantics. Reads remain on the
bounded observer/optic path and are not encoded as synthetic mutations.
No Jim-specific checkpoint, rope, causal-anchor, editor, or application
semantics enter the provider waist.

Review

The complete committed diff received:

a strict self-review against origin/main;
independent declaration-closure and publication-cascade reviews;
an independent final documentation-accuracy review;
a clean committed-diff Code Lawyer pass;
exact carrier/resource/hash consistency checks; and
the repository-defined seven-check full preflight.

No self-discovered issue remains open at publication. GitHub CI and review
feedback will be processed one finding at a time with focused RED/GREEN commits;
all threads will be resolved before the authorized merge.

Summary by CodeRabbit

New Features
- Added a checked provider conformance corpus covering reviewed cases, expected outcomes, and executor ownership.
- Added fixture-based conformance scenarios for package and host execution, including typed refusals and contract-mismatch handling.
Bug Fixes
- Strengthened validation for malformed, duplicate, mismatched, or unsupported conformance declarations.
Documentation
- Updated architecture, schema, changelog, and component documentation with corpus coverage and refreshed artifact identities.
Tests
- Expanded end-to-end conformance, determinism, and reproducibility checks.

…-conformance # Conflicts: # CHANGELOG.md

chatgpt-codex-connector · 2026-07-17T11:15:55Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

coderabbitai · 2026-07-17T11:16:19Z

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bae053e3-798d-48db-a418-ec6a7111b670

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

📝 Walkthrough

Walkthrough

The PR adds a twelve-case checked conformance corpus, canonical declaration validation, host/package execution coverage, refreshed provider resources and component digests, and documentation describing the corpus boundaries and ownership split.

Changes

Echo provider conformance

Layer / File(s)	Summary
Conformance corpus contract and decoder `crates/echo-wesley-gen/src/provider_artifacts.rs`, `tests/edict-provider-host-v1/tests/support/`, `tests/edict-provider-host-v1/tests/conformance_contract.rs`, `tests/edict-provider-host-v1/fixtures/provider-conformance-v1/`	The corpus now defines explicit typed cases; shared test code validates canonical CBOR structure, contract identity, ownership, required outcomes, and duplicate handling.
Host and package executable contracts `tests/edict-provider-host-v1/tests/host_contract.rs`, `tests/edict-provider-host-v1/tests/package_contract.rs`	Host- and package-owned declarations are dispatched to typed contract assertions covering lowering, verification, refusals, tampering, identity mismatches, capability denial, parity, and deterministic observations.
Regenerated resources and digest identities `crates/echo-edict-provider-/resources/`, `crates/echo-edict-provider-/src/`, `crates/echo-wesley-gen/assets/**/provider-manifest.echo.json`, `schemas/edict-provider/package/v1/provider-manifest.echo.json`, `xtask/src/provider_lowerer_component.rs`	CBOR resources, generated fixtures, semantic digest pins, manifests, and approved lowerer/verifier component hashes were updated.
Documentation and publication records `CHANGELOG.md`, `docs/architecture/application-contract-hosting.md`, `schemas/edict-provider/README.md`, `schemas/edict-provider/components/v1/README.md`, `crates/echo-edict-provider-*/README.md`	Documentation records the twelve obligations, executor ownership split, declaration-only evidence boundary, and refreshed component identities.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related issues

flyingrobots/echo#650 — Covers the conformance/parity slice implemented by the checked corpus, executable contract tests, and refreshed provider artifacts.

Possibly related PRs

flyingrobots/echo#671 — Shares the echo-wesley-gen provider-artifact generation work that now populates conformance cases.
flyingrobots/echo#672 — Shares the lowerer component attestation and approved SHA-256 identity surface.
flyingrobots/echo#675 — Shares verifier semantic-resource digest wiring and pinned framed digest tests.

Sequence Diagram(s)

sequenceDiagram
  participant ConformanceCorpus
  participant HostContract
  participant PackageContract
  participant Lowerer
  participant Verifier
  ConformanceCorpus->>HostContract: Decode host-owned declarations
  ConformanceCorpus->>PackageContract: Decode package-owned declarations
  PackageContract->>Lowerer: Submit validated lowering request
  Lowerer-->>PackageContract: Return canonical Target IR
  PackageContract->>Verifier: Submit Target IR verification request
  Verifier-->>PackageContract: Return semantic bundle and observation
  HostContract-->>HostContract: Assert typed refusals and rejection contracts

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 35.42% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title matches the main change: adding a reviewed Edict provider conformance and semantic-parity fixture.
Linked Issues check	✅ Passed	The PR covers the end-to-end conformance fixture, parity checks, negative corpus, pinned digests, and deterministic host/package execution required by `#657`.
Out of Scope Changes check	✅ Passed	All changes support the conformance fixture, generated artifacts, tests, or supporting docs; no unrelated code paths stand out.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch provider/657-provider-conformance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/echo-edict-provider-lowerer/tests/fixtures/generated_echo_dpo.rs`:
- Line 59: Regenerate the target-profile digest and dependent attestations
together so the generated identity chain is consistent. Update
TARGET_PROFILE_DIGEST in generated_echo_dpo.rs and refresh the target-profile
references in authority-facts.echo-dpo.cbor under both provider-lowerer and
provider-verifier resources; make no isolated manual update that leaves these
artifacts out of sync.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3051320b-328b-4e48-939b-eff12150c6ed

📥 Commits

Reviewing files that changed from the base of the PR and between decce43 and 47d0d85.

⛔ Files ignored due to path filters (31)

crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/components/lowerer.echo-dpo.component.wasm is excluded by !**/*.wasm
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/components/verifier.echo-dpo.component.wasm is excluded by !**/*.wasm
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/evidence/provenance.provider-generation.json is excluded by !**/generated/**
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/evidence/review.provider-generation.json is excluded by !**/generated/**
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/authority-facts.echo-dpo.cbor is excluded by !**/generated/**
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/authority-facts.echo-lawpack.cbor is excluded by !**/generated/**
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/lawpack.echo-dpo.cbor is excluded by !**/generated/**
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/schema.echo-provider-artifacts.cddl is excluded by !**/generated/**
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/target-profile.echo-dpo.cbor is excluded by !**/generated/**
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.conformance-corpus.cbor is excluded by !**/generated/**
schemas/edict-provider/components/v1/lowerer.echo-dpo.component.wasm is excluded by !**/*.wasm
schemas/edict-provider/components/v1/verifier.echo-dpo.component.wasm is excluded by !**/*.wasm
schemas/edict-provider/generated/v1/evidence/provenance.provider-generation.json is excluded by !**/generated/**
schemas/edict-provider/generated/v1/evidence/review.provider-generation.json is excluded by !**/generated/**
schemas/edict-provider/generated/v1/primary/authority-facts.echo-dpo.cbor is excluded by !**/generated/**
schemas/edict-provider/generated/v1/primary/authority-facts.echo-lawpack.cbor is excluded by !**/generated/**
schemas/edict-provider/generated/v1/primary/lawpack.echo-dpo.cbor is excluded by !**/generated/**
schemas/edict-provider/generated/v1/primary/schema.echo-provider-artifacts.cddl is excluded by !**/generated/**
schemas/edict-provider/generated/v1/primary/target-profile.echo-dpo.cbor is excluded by !**/generated/**
schemas/edict-provider/generated/v1/resources/resource.conformance-corpus.cbor is excluded by !**/generated/**
schemas/edict-provider/package/v1/components/lowerer.echo-dpo.component.wasm is excluded by !**/*.wasm
schemas/edict-provider/package/v1/components/verifier.echo-dpo.component.wasm is excluded by !**/*.wasm
schemas/edict-provider/package/v1/generated/evidence/provenance.provider-generation.json is excluded by !**/generated/**
schemas/edict-provider/package/v1/generated/evidence/review.provider-generation.json is excluded by !**/generated/**
schemas/edict-provider/package/v1/generated/primary/authority-facts.echo-dpo.cbor is excluded by !**/generated/**
schemas/edict-provider/package/v1/generated/primary/authority-facts.echo-lawpack.cbor is excluded by !**/generated/**
schemas/edict-provider/package/v1/generated/primary/lawpack.echo-dpo.cbor is excluded by !**/generated/**
schemas/edict-provider/package/v1/generated/primary/schema.echo-provider-artifacts.cddl is excluded by !**/generated/**
schemas/edict-provider/package/v1/generated/primary/target-profile.echo-dpo.cbor is excluded by !**/generated/**
schemas/edict-provider/package/v1/generated/resources/resource.conformance-corpus.cbor is excluded by !**/generated/**
tests/edict-provider-host-v1/Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (35)

CHANGELOG.md
crates/echo-edict-provider-lowerer/README.md
crates/echo-edict-provider-lowerer/resources/authority-facts.echo-dpo.cbor
crates/echo-edict-provider-lowerer/resources/authority-facts.echo-lawpack.cbor
crates/echo-edict-provider-lowerer/resources/lawpack.echo-dpo.cbor
crates/echo-edict-provider-lowerer/resources/target-profile.echo-dpo.cbor
crates/echo-edict-provider-lowerer/src/lib.rs
crates/echo-edict-provider-lowerer/tests/fixtures/generated_echo_dpo.rs
crates/echo-edict-provider-lowerer/tests/lowerer_contract.rs
crates/echo-edict-provider-verifier/README.md
crates/echo-edict-provider-verifier/resources/authority-facts.echo-dpo.cbor
crates/echo-edict-provider-verifier/resources/authority-facts.echo-lawpack.cbor
crates/echo-edict-provider-verifier/resources/lawpack.echo-dpo.cbor
crates/echo-edict-provider-verifier/resources/target-profile.echo-dpo.cbor
crates/echo-edict-provider-verifier/src/semantic_resources.rs
crates/echo-edict-provider-verifier/tests/verifier_contract.rs
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/provider-manifest.echo.json
crates/echo-wesley-gen/src/provider_artifacts.rs
crates/echo-wesley-gen/tests/provider_package_corpus.rs
crates/echo-wesley-gen/tests/provider_primary_artifacts.rs
docs/architecture/application-contract-hosting.md
schemas/edict-provider/README.md
schemas/edict-provider/components/v1/README.md
schemas/edict-provider/package/v1/provider-manifest.echo.json
scripts/verify-edict-provider-host-v1.sh
tests/edict-provider-host-v1/Cargo.toml
tests/edict-provider-host-v1/fixtures/provider-conformance-v1/ORIGIN.toml
tests/edict-provider-host-v1/fixtures/provider-conformance-v1/canonicalization-profile.json
tests/edict-provider-host-v1/fixtures/provider-conformance-v1/source.edict
tests/edict-provider-host-v1/tests/conformance_contract.rs
tests/edict-provider-host-v1/tests/host_contract.rs
tests/edict-provider-host-v1/tests/package_contract.rs
tests/edict-provider-host-v1/tests/support/conformance.rs
tests/edict-provider-host-v1/tests/support/mod.rs
xtask/src/provider_lowerer_component.rs

flyingrobots · 2026-07-17T11:25:26Z

@coderabbitai review

coderabbitai · 2026-07-17T11:25:36Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

flyingrobots · 2026-07-17T11:26:31Z

Code Lawyer Activity Summary

Audited subject: 47d0d8590bffe0180b987f6ee1d58e5a8611c65f

#	Source	Severity	Area	Disposition	Commit / evidence
1	Committed-diff self-audit	—	Complete `origin/main...HEAD` diff	Clean; no self-discovered correctness, determinism, ownership, style, or documentation issue	`47d0d8590`; independent declaration, publication-cascade, and docs reviews; seven-check full preflight
2	CodeRabbit `discussion_r3602716340`	P1 claim	Target-profile identity chain	False positive; no code change. The PR already changes the framed digest from `ad7f10e1…` to `eedf7bdb…`; the raw identity is separately `a2ecfe50…`. Focused tests recomputed the framed digest from the current bytes and validated every authority-facts digest edge. Thread replied to and resolved.	Existing `47d0d8590`; `packaged_raw_and_domain_framed_identities_are_distinct_and_pinned` PASS; `computed_digest_edges_and_authority_partition_are_exact` PASS
3	CodeRabbit summary heuristic	P5 / informational	Docstring coverage	No change. The warning concerns private/test-only helpers; repository Rustdoc, strict Clippy/missing-docs, and all local/CI documentation gates pass. Adding ceremonial comments would not strengthen a public contract.	Full local preflight PASS; Rustdoc PASS; all provider Clippy lanes PASS

Closure evidence:

Worktree clean; no review-driven source change was needed.
cargo +1.90.0 xtask pr-preflight --full: 7/7 checks passed.
GitHub checks: 40 passed, 0 pending, 0 failing.
Unresolved review threads: 0.
CodeRabbit review: completed on the exact head.
Doghouse merge-check result: merge_ready_pending_approval; only the formal approval rule remains, with no live code, CI, documentation, or review-thread blocker.

The bounded claim remains unchanged: this is provider-generation/lowering/verifying/package conformance evidence, not Echo installation, runtime authority, execution, observation, or a runtime receipt.

flyingrobots · 2026-07-17T11:26:43Z

✅ Addressed in commit 47d0d85 (verification-only disposition: the alleged missing digest update is already present in that commit; no follow-up code change was required).

Acked review threads:

discussion_r3602716340

flyingrobots added 17 commits July 17, 2026 00:32

Prove packaged provider parity

0e88fea

Bind provider semantic and release identities

d687fbf

Bind generated helpers to provider bundle

d8461df

Reproduce provider conformance observation

3b7c327

Execute the first provider conformance case

2e0dee9

Reject noncanonical provider output

a99df9a

Deny ambient provider authority

1b74f59

Reject dropped provider obstructions

d4a2852

Bind conformance declarations to executors

cb50f8d

Register host conformance executors

e950d00

Register semantic conformance laws

f20c4a8

Reject package material tampering

56ea384

Reject stale provider helper bindings

05b8fc5

Declare complete provider conformance corpus

3935d12

Publish complete provider conformance corpus

d291450

Merge remote-tracking branch 'origin/main' into provider/657-provider…

3ac8771

…-conformance # Conflicts: # CHANGELOG.md

Run provider conformance declarations in CI

47d0d85

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread crates/echo-edict-provider-lowerer/tests/fixtures/generated_echo_dpo.rs

flyingrobots merged commit fef8dc3 into main Jul 17, 2026
40 checks passed

flyingrobots deleted the provider/657-provider-conformance branch July 17, 2026 11:27

flyingrobots mentioned this pull request Jul 17, 2026

Feature: Create Echo-owned provider implementation issues flyingrobots/edict#142

Closed

6 tasks

coderabbitai Bot mentioned this pull request Jul 17, 2026

Goalpost: Echo Edict Provider Walking Skeleton #650

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prove Edict provider conformance and semantic parity#677

Prove Edict provider conformance and semantic parity#677
flyingrobots merged 17 commits into
mainfrom
provider/657-provider-conformance

flyingrobots commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

flyingrobots commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

flyingrobots commented Jul 17, 2026

Uh oh!

flyingrobots commented Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

flyingrobots commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Outcome

Plain-English architecture walkthrough

Exact declarative corpus

Exact checked occurrence

RED / GREEN evidence

Reproduction commands

Dependency rationale

Documentation impact

Compatibility notes

Review

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flyingrobots commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flyingrobots commented Jul 17, 2026

Code Lawyer Activity Summary

Uh oh!

flyingrobots commented Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

flyingrobots commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading