Assemble digest-locked Edict provider package - #674
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThe PR adds a deterministic Edict provider-package pipeline: canonical contracts and manifests, digest-based assembly and admission, symlink-safe corpus publication, package-local asset synchronization, expanded semantic validation, host readiness tests, CI drift checks, and supporting documentation. ChangesEdict provider package
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related issues
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@crates/echo-wesley-gen/assets/v1/repository/crates/echo-edict-canonical/src/lib.rs.source`:
- Around line 338-358: Introduce a decoder-wide node/allocation budget and
enforce it in checked_collection_length and the container decoding logic around
the map/array reservation and push operations. Charge map keys and values as
separate nodes, validate each requested cardinality before reserve or push, and
return a typed CanonicalValueError when the budget is exceeded instead of
allowing oversized allocations.
In
`@crates/echo-wesley-gen/assets/v1/repository/crates/echo-wesley-gen/Cargo.toml.source`:
- Around line 6-12: Align the carrier manifest with the available assets by
either adding crates/echo-wesley-gen/src/main.rs and
crates/echo-wesley-gen/README.md to the exact provider source inventory, or
removing the corresponding default-run and readme declarations from the
manifest; ensure the assembled package passes Cargo validation and preserves
only references to shipped files.
In `@crates/echo-wesley-gen/src/bin/echo-edict-provider-assets.rs`:
- Around line 358-374: Sort both actual_assets and expected_assets before
comparing them, preserving the existing inventory validation while making
ordering independent of Cargo output or ASSETS definition order. When they
differ, update the bail! error in this validation block to include the expected
and actual asset path lists, not only their counts, so same-length mismatches
identify the exact paths.
In `@det-policy.yaml`:
- Around line 46-49: Update the echo-edict-provider-artifacts entry in
det-policy.yaml to include the repository’s .gitattributes file in its paths,
ensuring changes to exact-byte preservation rules remain classified as
DET_CRITICAL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6c566ca2-76bb-4f50-b604-f499cefbb4f8
⛔ Files ignored due to path filters (51)
crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/components/lowerer.echo-dpo.component.wasmis excluded by!**/*.wasmcrates/echo-wesley-gen/assets/v1/edict-provider/package/v1/components/verifier.echo-dpo.component.wasmis excluded by!**/*.wasmcrates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/evidence/provenance.provider-generation.jsonis excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/evidence/review.provider-generation.jsonis excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/authority-facts.echo-dpo.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/authority-facts.echo-lawpack.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/generated-artifact-profile.echo-dpo-registration.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/lawpack.echo-dpo.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/schema.echo-provider-artifacts.cddlis excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/primary/target-profile.echo-dpo.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.conformance-corpus.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.lawpack-compatibility.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.lawpack-exports.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.lawpack-target-adapter.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.lawpack-verifier.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-bundle-profile.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-cost-algebra.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-footprint-algebra.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-intrinsics.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-ir.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-lowerer-contract.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-obstruction-taxonomy.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-operation-profiles.cboris excluded by!**/generated/**crates/echo-wesley-gen/assets/v1/edict-provider/package/v1/generated/resources/resource.target-verifier-contract.cboris excluded by!**/generated/**schemas/edict-provider/generated/v1/evidence/provenance.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/generated/v1/evidence/review.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/package/v1/components/lowerer.echo-dpo.component.wasmis excluded by!**/*.wasmschemas/edict-provider/package/v1/components/verifier.echo-dpo.component.wasmis excluded by!**/*.wasmschemas/edict-provider/package/v1/generated/evidence/provenance.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/package/v1/generated/evidence/review.provider-generation.jsonis excluded by!**/generated/**schemas/edict-provider/package/v1/generated/primary/authority-facts.echo-dpo.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/primary/authority-facts.echo-lawpack.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/primary/generated-artifact-profile.echo-dpo-registration.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/primary/lawpack.echo-dpo.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/primary/schema.echo-provider-artifacts.cddlis excluded by!**/generated/**schemas/edict-provider/package/v1/generated/primary/target-profile.echo-dpo.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.conformance-corpus.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.lawpack-compatibility.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.lawpack-exports.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.lawpack-target-adapter.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.lawpack-verifier.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-bundle-profile.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-cost-algebra.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-footprint-algebra.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-intrinsics.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-ir.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-lowerer-contract.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-obstruction-taxonomy.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-operation-profiles.cboris excluded by!**/generated/**schemas/edict-provider/package/v1/generated/resources/resource.target-verifier-contract.cboris excluded by!**/generated/**tests/edict-provider-host-v1/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (46)
.gitattributes.github/workflows/ci.ymlCHANGELOG.mdcrates/echo-wesley-gen/README.mdcrates/echo-wesley-gen/assets/v1/edict-provider/contracts/v1/edict-provider-contracts.cddlcrates/echo-wesley-gen/assets/v1/edict-provider/contracts/v1/manifest.jsoncrates/echo-wesley-gen/assets/v1/edict-provider/echo-provider-semantics-v1.jsoncrates/echo-wesley-gen/assets/v1/edict-provider/generation-settings-v1.jsoncrates/echo-wesley-gen/assets/v1/edict-provider/package/v1/provider-manifest.echo.jsoncrates/echo-wesley-gen/assets/v1/repository/Cargo.lock.sourcecrates/echo-wesley-gen/assets/v1/repository/Cargo.toml.sourcecrates/echo-wesley-gen/assets/v1/repository/crates/echo-edict-canonical/Cargo.toml.sourcecrates/echo-wesley-gen/assets/v1/repository/crates/echo-edict-canonical/src/lib.rs.sourcecrates/echo-wesley-gen/assets/v1/repository/crates/echo-wesley-gen/Cargo.toml.sourcecrates/echo-wesley-gen/assets/v1/repository/rust-toolchain.toml.sourcecrates/echo-wesley-gen/src/bin/echo-edict-provider-artifacts.rscrates/echo-wesley-gen/src/bin/echo-edict-provider-assets.rscrates/echo-wesley-gen/src/bin/echo-edict-provider-package.rscrates/echo-wesley-gen/src/lib.rscrates/echo-wesley-gen/src/main.rscrates/echo-wesley-gen/src/provider_artifacts.rscrates/echo-wesley-gen/src/provider_corpus.rscrates/echo-wesley-gen/src/provider_corpus_fs.rscrates/echo-wesley-gen/src/provider_package.rscrates/echo-wesley-gen/src/provider_semantics.rscrates/echo-wesley-gen/tests/provider_artifact_corpus.rscrates/echo-wesley-gen/tests/provider_canonical_contract.rscrates/echo-wesley-gen/tests/provider_contract_pack.rscrates/echo-wesley-gen/tests/provider_generation_input.rscrates/echo-wesley-gen/tests/provider_generation_provenance.rscrates/echo-wesley-gen/tests/provider_generation_review.rscrates/echo-wesley-gen/tests/provider_package.rscrates/echo-wesley-gen/tests/provider_package_assets.rscrates/echo-wesley-gen/tests/provider_package_corpus.rscrates/echo-wesley-gen/tests/provider_primary_artifacts.rscrates/echo-wesley-gen/tests/provider_semantic_source.rsdet-policy.yamldocs/architecture/application-contract-hosting.mdschemas/edict-provider/README.mdschemas/edict-provider/echo-provider-semantics-v1.jsonschemas/edict-provider/package/README.mdschemas/edict-provider/package/v1/provider-manifest.echo.jsonscripts/tests/classify_changes.test.cjsscripts/verify-edict-provider-host-v1.shtests/edict-provider-host-v1/Cargo.tomltests/edict-provider-host-v1/tests/package_contract.rs
Closes #655
Outcome
This completes the digest-locked Echo Edict provider package. The checked distribution now contains:
It also proves that the exact checked package is ready for the pinned native Edict host boundary before any guest component execution. It does not claim Echo installation, runtime admission, scheduling, execution, commitment, observation, receipt production, or runtime authority.
Plain-English walkthrough
echo-wesley-genarchive. Owner, package, carrier, and Cargo archive inventories must corroborate exactly.Soundness and refusal
RED / GREEN evidence
The development REDs were carried by the focused semantic-closure, package-readiness, and archive-carrier witnesses:
They failed closed while the package exposed only the earlier nine bindings, before the native package contract existed, and before the crate archive carried the complete exact input closure.
The completed GREEN gate is:
The full preflight passed all seven repository checks. The prompt-era
cargo xtask verifycommand does not exist in this checkout;cargo xtask pr-preflight --fullis the repository-defined final branch gate.The actual extracted Cargo archive was also compiled successfully with local patches for the two unpublished direct Echo dependencies:
Cargo packaged 78 files and verified the extracted crate.
Dependency rationale
c75c3f550d049485ba00eae0dc272c6dd6aca11f. That revision contains the schema-registry, bounded recursive-dispatch, component-preflight, and request-proof contract being tested; an exact revision prevents a moving host proof.wesley-core = 0.3.0-alpha.1is the published additive generation-contract release used by Echo.echo-edict-canonical = 0.1.0andwarp-core = 0.1.1are not yet available from crates.io. Ordinary packaging therefore stops at registry dependency resolution, while the local-patch witness proves the selected extracted archive itself is complete. Publication must follow the documented Echo dependency release order; this PR does not publish crates.Documentation and compatibility
Updated the changelog, provider/crate/package READMEs, application-contract-hosting architecture guide, determinism classification, CI gates, and exact-byte Git attributes.
Compatibility notes:
Review
A strict full-branch self-review and independent Code Lawyer review are clean. The review specifically rechecked all 24 schema bindings, the 14-resource field-level digest closure, adjacent primary identity edges, exact c75 native preflight, the 35-carrier Cargo archive inventory, recursive-dispatch soundness, exact-byte checkout portability, and the Echo runtime-authority boundary.
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Tests