chore: delete zombie crates, TTD stack, and stale audit reports#649
Merged
Conversation
Remove crates with zero consumers, all recoverable from git history: echo-wasm-bindings (browser demo kernel), echo-ttd, ttd-protocol-rs, echo-session-proto, echo-config-fs, the untracked ttd-browser prebuilt artifact, packages/ttd-protocol-ts, and the empty src/transport/ dir. The TTD stack's future home is warp-ttd. Also remove the 'cargo xtask wesley' subcommand (existed solely to sync-check the deleted TTD protocol consumers) and the stale point-in-time audit reports under docs/audit/ and docs/audits/. Scrub all references: workspace members and dependencies, CI clippy lanes (ci.yml, macos-local.yml), det-policy.yaml, verify-local.sh, unordered-ABI allowlist, README key-crates list. CHANGELOG updated. Verified: cargo check --workspace, cargo test -p xtask (90 passed), cargo clippy -p xtask, cargo fmt --check all pass.
Contributor
|
Important Review skippedToo many files! This PR contains 501 files, which is 351 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (501)
You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughRemoves obsolete Echo application, configuration, session-protocol, TTD, WASM, and generated consumer crates and APIs. Workspace metadata, CI targets, determinism policies, local verification scripts, documentation, and the ChangesLegacy crate and protocol removal
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 101baf4631
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
echo-app-core lost its last production consumer when echo-config-fs was removed; its only remaining dependent was echo-dry-tests' InMemoryConfigStore, which nothing consumed either. Scrubbed workspace members/deps, CI clippy lanes, and det-policy. cargo check --workspace and echo-dry-tests tests pass.
Owner
Author
Code Lawyer — Phase I self-audit findingsDeep audit of
No new runtime logic, nondeterminism, race, or CI-lane defect was found in the crate deletion itself. Historical CHANGELOG references are intentionally retained. Cc: @codex — second opinion requested. |
There was a problem hiding this comment.
💡 Codex Review
echo/crates/echo-dry-tests/Cargo.toml
Lines 25 to 26 in bf92192
Drop serde after deleting the config fake
With crates/echo-dry-tests/src/config.rs gone, retained echo-dry-tests/src no longer uses serde/serde_json (rg finds no Serialize/Deserialize), yet cargo tree -p echo-dry-tests --edges normal --depth 1 still pulls serde as a direct normal dependency and the dev dependency remains too. Every normal consumer of the test fixture crate now pays for an unused serialization dependency that existed only for the deleted fake.
Line 43 in bf92192
Regenerate the pnpm lockfile after package removal
The workspace package packages/ttd-protocol-ts is deleted here, but the lockfile still declares it as an importer and keeps its zod@4.3.6 resolution/snapshot. Lockfile-driven audits or dependency inventory now report a package and dependency that no longer exist in the workspace, so the lockfile should be regenerated with that importer removed.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
Cc @codex for second opinion. |
Owner
Author
Cc @codex for second opinion. |
Owner
Author
Cc @codex for second opinion. |
Owner
Author
Cc @codex for second opinion. |
Owner
Author
Cc @codex for second opinion. |
Owner
Author
Cc @codex for second opinion. |
Owner
Author
Cc @codex for second opinion. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf921928ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Code Lawyer final audit found one additional paired dead-route defect:
Disposition: replace them with repository-relative Markdown links and guard against resurrection of the docs-site route form. Cc: @codex |
|
Summary
Testing
|
|
Summary
Testing
|
Owner
Author
Code Lawyer — additional self-audit findings
@codex, second opinion requested on severity, scope, and the smallest durable witnesses. |
|
Summary
Testing
|
|
Summary
Testing
|
Owner
Author
Code Lawyer — additional self-audit finding
@codex, second opinion requested on the fail-closed boundary and regression coverage. |
Owner
Author
Code Lawyer — additional self-audit finding
@codex, second opinion requested on whether capability/law admission should live in an opened-optic registry, installed contract package evidence, or another trusted host authority. |
Owner
Author
Code Lawyer — additional full-clippy findings
@codex, second opinion requested on issue grouping and the smallest lint-preserving test rewrites. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ardown # Conflicts: # docs/architecture/application-contract-hosting.md
Owner
Author
Activity SummaryThe teardown and audit loop is closed at
Verification
No warp-core decomposition or speculative nit cleanup was included. |
flyingrobots
enabled auto-merge
July 13, 2026 12:57
Owner
Author
Closure addendumFresh CI on final head CodeRabbit completed with a no-findings skip because 501 files exceed its 150-file limit. All 21 review threads remain resolved. A normal merge was attempted and correctly refused by the repository ruleset, which requires one approval and approval of the last push. Auto-merge is now enabled with merge-commit strategy. No administrator bypass was used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Post-audit teardown, per triage decisions:
echo-wasm-bindings(browser demo kernel),echo-ttd,ttd-protocol-rs,echo-session-proto,echo-config-fs, plus the untrackedttd-browserprebuilt artifact and emptysrc/transport/. The TTD stack's future home is warp-ttd.packages/ttd-protocol-ts(generated consumer of the removed protocol).cargo xtask wesley— existed solely to sync-check the removed TTD protocol consumers (xtask: 9,311 → 9,094 lines).docs/audit/,docs/audits/).Verification
cargo check --workspace✅ (proves nothing depended on the deleted crates)cargo test -p xtask— 90 passed ✅cargo clippy -p xtask --all-targets✅cargo fmt --all -- --check✅Net: −9,622 lines.
Summary by CodeRabbit
Removed
Documentation
Chores