Skip to content

feat(warp-core): add runtime WAL config boundary - #593

Merged
flyingrobots merged 1 commit into
mainfrom
cycle/554-runtime-wal-store-adapter-boundary
Jun 21, 2026
Merged

feat(warp-core): add runtime WAL config boundary#593
flyingrobots merged 1 commit into
mainfrom
cycle/554-runtime-wal-store-adapter-boundary

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Summary

  • adds TrustedRuntimeWalConfig and TrustedRuntimeWalStoreKind so the trusted host configures the runtime WAL adapter explicitly
  • moves TrustedRuntimeWal onto a private store adapter that implements WalStorePort, preserving the existing in-memory adapter for fast tests
  • keeps TrustedRuntimeApp limited to submit/observe surfaces; no WAL append, flush, truncate, manifest, tick, or recovery authority is exposed to app code
  • adds a regression proving the WAL ACK path runs through the host-owned adapter boundary

Closes #554

Validation

  • cargo test -p warp-core --features "native_rule_bootstrap trusted_runtime host_test" --test trusted_runtime_host_loop_tests runtime_wal_ack
  • cargo clippy -p warp-core --features "native_rule_bootstrap trusted_runtime host_test" --test trusted_runtime_host_loop_tests -- -D warnings
  • cargo check -p warp-core --features "native_rule_bootstrap trusted_runtime host_test"
  • cargo fmt --check
  • pnpm exec prettier --check CHANGELOG.md docs/design/reference-trusted-runtime-host-loop.md docs/design/causal-wal-hardening-matrix.md
  • pnpm exec markdownlint-cli2 CHANGELOG.md docs/design/reference-trusted-runtime-host-loop.md docs/design/causal-wal-hardening-matrix.md
  • scripts/check_spdx.sh CHANGELOG.md docs/design/reference-trusted-runtime-host-loop.md docs/design/causal-wal-hardening-matrix.md crates/warp-core/src/lib.rs crates/warp-core/src/trusted_runtime_host.rs crates/warp-core/tests/trusted_runtime_host_loop_tests.rs
  • git diff --check
  • pre-commit hook: warp-core clippy/check and markdownlint
  • pre-push hook: warp-core lib tests, trusted runtime host test slices, prettier touched docs

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes and 34 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4a2c6da0-04ee-4fff-8f79-7b4096eccdc3

📥 Commits

Reviewing files that changed from the base of the PR and between 0b07e05 and 7626fd4.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • crates/warp-core/src/lib.rs
  • crates/warp-core/src/trusted_runtime_host.rs
  • crates/warp-core/tests/trusted_runtime_host_loop_tests.rs
  • docs/design/causal-wal-hardening-matrix.md
  • docs/design/reference-trusted-runtime-host-loop.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cycle/554-runtime-wal-store-adapter-boundary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@flyingrobots flyingrobots moved this from Todo to In Progress in Continuum Stack Convergence Jun 21, 2026
@flyingrobots
flyingrobots merged commit 0275bc1 into main Jun 21, 2026
36 checks passed
@flyingrobots
flyingrobots deleted the cycle/554-runtime-wal-store-adapter-boundary branch June 21, 2026 00:25
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Continuum Stack Convergence Jun 21, 2026
@flyingrobots flyingrobots mentioned this pull request Jun 21, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[GP1-S1] Runtime WAL Store Adapter Boundary

1 participant