Feat: add qw warpspace locate - #27
Conversation
|
Warning Review limit reached
More reviews will be available in 6 minutes and 57 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdds the Changeswarpspace locate command
Sequence Diagram(s)sequenceDiagram
actor User
participant CLI as cli.mjs / runWarpspace
participant Locator as locator.mjs / locateWarpspacePath
participant FS as Filesystem
User->>CLI: qw warpspace locate <path> --lock --root --basis --json
CLI->>CLI: parseWarpspaceLocateArgs → options, positionals
CLI->>Locator: locateWarpspacePath({ inputPath, lockPath, root, cwd, basis })
Locator->>FS: readFile(lockPath) → JSON
Locator->>Locator: assertUnderRoot(inputPath, root)
Locator->>FS: realpath(deepestExistingAncestor)
Locator->>Locator: assertNoSymlinkEscape via realpath
Locator->>Locator: findRepoMatch(repos, inputPath) → longest prefix repo
Locator->>Locator: renderWarpLocator(basis, warpspace, segments)
Locator-->>CLI: { locator, basisLocator, typedLocator, runtimeProjection }
CLI-->>User: JSON output or plain locator string
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Self-Code Review Findings@codex please confirm these findings before remediation. Scope: reviewed
Mechanical checks run after review:
No Markdown style violations were found in the changed Markdown files. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
continuum/apps/warp/src/cli.mjs
Line 371 in eb95f94
Use a locate-domain fallback JSON error code
When qw warpspace locate --json hits an uncoded error, such as malformed warpspace.lock.json throwing from JSON.parse, this shared serializer emits kind: "warp.warpspace.locate.error.v1" but falls back to code: "EINSTALL". JSON callers that dispatch on machine-readable locate errors now receive an install-domain code for a locate failure; pass a command-specific fallback code or wrap locate failures before serialization.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Self-Review ResolutionResolved both findings from
Validation after remediation:
Current PR head: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/warp/src/locator.mjs`:
- Around line 131-138: The pathExists() function is using stat() which follows
symlinks to their targets, causing dangling symlinks to be skipped during the
upward directory walk in deepestExistingAncestor(). This breaks symlink-escape
validation by validating the wrong ancestor path. Change pathExists() to use
lstat() instead of stat() so it detects symlinks themselves rather than their
nonexistent targets. Additionally, add error handling in assertNoSymlinkEscape()
to catch and handle the case where realpath() fails when encountering a dangling
symlink after the path fix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 417655e6-6079-432c-bfeb-c8c9f9178f07
📒 Files selected for processing (6)
CHANGELOG.mdapps/warp/README.mdapps/warp/src/cli.mjsapps/warp/src/locator.mjsapps/warp/test/warp-warpspace.test.mjsdocs/warpspaces/README.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
**: # AGENTS.mdRole
Continuum is the coordination spine for the active stack. It does not own a
runtime implementation, a substrate, or a parallel ontology. It owns shared
truth across Echo,git-warp,warp-ttd, and Wesley.Git Safety
- Never amend commits.
- Never rebase.
- Never force git operations.
- Stage only the files written in the current turn.
- Commit each completed slice in the same turn.
Process
- Read METHOD.md before changing structure.
- Keep active work in
docs/design/.- Keep concrete work in
docs/method/backlog/.- Keep retros in
docs/method/retro/.- Update docs/BEARING.md and docs/VISION.md
only at cycle boundaries.Doctrine
- Continuum owns coordination truth, not substrate truth.
- Shared nouns need one authored home and explicit publication boundaries.
- Cross-repo witness and compatibility truth beats hand-wavy alignment claims.
- No shadow schemas, no shadow vocabularies, no shadow ownership.
Files:
docs/warpspaces/README.mdapps/warp/README.mdCHANGELOG.mdapps/warp/src/cli.mjsapps/warp/src/locator.mjsapps/warp/test/warp-warpspace.test.mjs
🔇 Additional comments (6)
CHANGELOG.md (1)
11-13: LGTM!apps/warp/README.md (1)
35-35: LGTM!Also applies to: 57-59, 87-87
docs/warpspaces/README.md (1)
20-23: LGTM!apps/warp/src/locator.mjs (1)
1-130: LGTM!Also applies to: 139-145, 150-191, 200-203
apps/warp/src/cli.mjs (1)
2-2: LGTM!Also applies to: 297-329, 366-372, 510-544, 599-600, 620-622
apps/warp/test/warp-warpspace.test.mjs (1)
6-6: LGTM!Also applies to: 661-816, 1109-1149
Activity Summary@codex review loop completed for
Validation:
No additional self-discovered issues remain after the PR-thread queue was resolved. |
|
To use Codex here, create an environment for this repo. |
1 participant
Summary
qw warpspace locatewith--lock,--root,--cwd,--basis, and--jsonwarp.locator.v1data, renderedwarp://andwarp@<basis>://locators, and runtime projection metadata markedhashScope: excludedValidation
node --test apps/warp/test/*.test.mjs-> 25/25 passgit diff --check-> passgit diff --cached --check-> pass before commitnpx --yes markdownlint-cli2 CHANGELOG.md apps/warp/README.md docs/warpspaces/README.md-> passnode apps/warp/bin/warp.mjs warpspace --help-> passnode apps/warp/bin/warp.mjs warpspace locate --help-> passJim smoke test
From
/Users/james/git/jim:Resolved to
warp://jim/repo/echo/package.jsonandwarp@basis:jim-local://jim/repo/echo/package.jsonwith the runtime projection outside hash scope.