Remove documentation about metadata#13133
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inaccuracy in the documentation regarding Android network policy configuration within Flutter. It removes instructions for a metadata tag that was found to be non-functional and clarifies the specific scope of the network security configurations, ensuring the documentation provides correct and actionable information for developers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes documentation for the unused io.flutter.network-policy metadata tag on Android. The changes are applied consistently to the text and code examples. I've added one suggestion to avoid a duplicated note to improve conciseness.
Note: Security Review has been skipped due to the limited scope of the PR.
src/content/release/breaking-changes/network-policy-ios-android.md
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit 2e52ec6): https://flutter-docs-prod--pr13133-remove-network-metadata-3tmtz4tx.web.app |
|
This documentation was added to support the breaking changes in: flutter/engine#20218 "--disallow-insecure-connections" is used in neither Android nor iOS. This breaking change documentation only re-iterates information about the Android, iOS networking policies and therefore only affects Android, iOS sockets - not Dart/Flutter sockets. This is stated on the page, but the page also makes it seem like there's a way around it. I have attempted to clear this up and highlight this. But I can't help asking: Should we just remove the documentation? |
It turns out the metadata tag for network policy in the Android embedder is not connected to the engine.
Addresses: flutter/flutter#183153
Presubmit checklist
of 80 characters or fewer.