Skip to content

Remove documentation about metadata#13133

Merged
sfshaza2 merged 4 commits intoflutter:mainfrom
mboetger:remove-network-metadata
Mar 4, 2026
Merged

Remove documentation about metadata#13133
sfshaza2 merged 4 commits intoflutter:mainfrom
mboetger:remove-network-metadata

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented Mar 3, 2026

It turns out the metadata tag for network policy in the Android embedder is not connected to the engine.

Addresses: flutter/flutter#183153

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@mboetger mboetger requested review from a team and sfshaza2 as code owners March 3, 2026 02:37
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inaccuracy in the documentation regarding Android network policy configuration within Flutter. It removes instructions for a metadata tag that was found to be non-functional and clarifies the specific scope of the network security configurations, ensuring the documentation provides correct and actionable information for developers.

Highlights

  • Documentation Correction: Removed incorrect documentation that instructed users to add a specific metadata entry (io.flutter.network-policy) to the Android manifest for network policy configuration, as this tag is not connected to the Flutter engine.
  • Clarity on Network Policy Scope: Added a clarification stating that the described Android network security configuration only controls native Android sockets and does not affect HTTP traffic using Dart sockets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/content/release/breaking-changes/network-policy-ios-android.md
    • Removed documentation instructing the addition of a metadata entry for io.flutter.network-policy in the Android manifest.
    • Removed corresponding XML examples that included the io.flutter.network-policy metadata tag.
    • Added a note clarifying that the network security configuration only applies to native Android sockets and not Dart sockets.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes documentation for the unused io.flutter.network-policy metadata tag on Android. The changes are applied consistently to the text and code examples. I've added one suggestion to avoid a duplicated note to improve conciseness.

Note: Security Review has been skipped due to the limited scope of the PR.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 3, 2026

Visit the preview URL for this PR (updated for commit 2e52ec6):

https://flutter-docs-prod--pr13133-remove-network-metadata-3tmtz4tx.web.app

@mboetger
Copy link
Contributor Author

mboetger commented Mar 3, 2026

@Sfshaza

This documentation was added to support the breaking changes in:

flutter/engine#20218
flutter/engine#20492
flutter/engine#20733
Since then, all of the functionality has been removed.

"--disallow-insecure-connections" is used in neither Android nor iOS.
"--domain-network-policy" is used by the Android embedder, but not by the engine. So it does nothing.

This breaking change documentation only re-iterates information about the Android, iOS networking policies and therefore only affects Android, iOS sockets - not Dart/Flutter sockets. This is stated on the page, but the page also makes it seem like there's a way around it.

I have attempted to clear this up and highlight this. But I can't help asking: Should we just remove the documentation?

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 6102231 into flutter:main Mar 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants