[simplistic_editor] - Fix delete key on desktop and backspace key on Web#1458
Merged
domesticmouse merged 4 commits intoflutter:mainfrom Oct 5, 2022
Merged
Conversation
Contributor
|
Can you please re-format for stable? |
bleroux
changed the title
Renzo-Olivares
approved these changes
Oct 4, 2022
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM besides my one comment. Thanks for making this change!
Contributor
Author
|
@domesticmouse This PR is almost ready to land. I don't know how to disable this step from CI : When it will be ready, thank you to merge it or to tell me how I should proceed (simply push the |
Contributor
|
We don't have autosubmit wired up in this repo. Please ignore the failures in the beta web verify. It needs to be updated to honour the beta CI cutout list. |
Contributor
|
Please feel free to land once the other CI tasks turn green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
simplistic_editorsample to fix some issues related todeleteandbackspacekeys.backspacekeys was handled by both the web browser and the framework which leads to a selection state entanglement. (see Simplistic Editor: unexpected behavior of TextInputClient on web #1413 and SimplisticEditor: Strange behavior which text changing on click #1450)deleteandbackspacewere not differentiated.For full context, see #1424 (comment)
Related issues
Fixes #1450
Fixes #1413