[packages] Adding fixes to get xdg-settings working.#4452
[packages] Adding fixes to get xdg-settings working.#4452yusuf-goog wants to merge 1 commit intoflutter:mainfrom
Conversation
|
@stuartmorgan if you want to merge this into yours or you can copy the code over |
|
FYI: successful build with this change including @stuartmorgan code: |
|
I'm merging it in to the main PR, since just adding a shell script that we're not using anywhere means there's no context or testing of the change. |
There was a problem hiding this comment.
nit: I am not sure what the google style doc says but in shell I prefer to use {} with variable references.
There was a problem hiding this comment.
nit: I am not sure what the google style doc says but in shell I prefer to use {} with variable references.
That is the Google Bash style preference as well.
There was a problem hiding this comment.
Awesome! Thanks Stuart.
This change sets up a .desktop file for our cipd chrome package which is required to get xdg-settings working. Unblocks: flutter#4223 Bug:flutter/flutter#130074
|
@stuartmorgan ok, i'll close this PR then. Please pick up this latest version of the file. |
|
I believe I've applied all of the missing bracing to my version. (My copy has some simplification and some added use of constants instead of repeat strings, so it's not just a case of copying it over.) |
3 participants
This change sets up a .desktop file for our cipd chrome package which is required to get xdg-settings working.
Unblocks: #4223
Bug:flutter/flutter#130074
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.