[ci] Switch Android unit tests to LUCI#4406
Conversation
Enables various new LUCI targets and removes the corresponding Cirrus versions: - The parts of `repo_checks` that have been migrated. - Android platform tests other than FTL. - Web platform tests. Since the Cirrus Android platform tests are now doing less work, the number of shards has been reduced slightly. Part of flutter/flutter#114373
This reverts commit 548e6da.
|
@reidbaker What do you think of the patterns I'm introducing here? The background here is that the version of JDK 11 we have available for LUCI has a crash when compiling the
I'm also definitely open to completely different ways of doing this if you have a preferred pattern. |
There was a problem hiding this comment.
Great readability improvements.
| public static int SDK_VERSION = Build.VERSION.SDK_INT; | ||
|
|
||
| @ChecksSdkIntAtLeast(api = Build.VERSION_CODES.P) | ||
| public static boolean supportsDistortionCorrection() { |
There was a problem hiding this comment.
I find these types of classes aid in readability a ton. That said it is even better when there are breadcrumbs to the source of truth but are annoying to find during a refactor and this is already a net improvement. To that end I have added suggestions with links to the android docs for at many as I could find.
...era/camera_android/android/src/main/java/io/flutter/plugins/camera/SdkCapabilityChecker.java
Show resolved
Hide resolved
...era/camera_android/android/src/main/java/io/flutter/plugins/camera/SdkCapabilityChecker.java
Show resolved
Hide resolved
...era/camera_android/android/src/main/java/io/flutter/plugins/camera/SdkCapabilityChecker.java
Show resolved
Hide resolved
...era/camera_android/android/src/main/java/io/flutter/plugins/camera/SdkCapabilityChecker.java
Show resolved
Hide resolved
...era/camera_android/android/src/main/java/io/flutter/plugins/camera/SdkCapabilityChecker.java
Show resolved
Hide resolved
...era/camera_android/android/src/main/java/io/flutter/plugins/camera/SdkCapabilityChecker.java
Show resolved
Hide resolved
Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com>
flutter/packages@369ee7e...6889cca 2023-07-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.3 to 2.20.4 (flutter/packages#4490) 2023-07-15 stuartmorgan@google.com [ci] Switch Android unit tests to LUCI (flutter/packages#4406) 2023-07-15 stuartmorgan@google.com [ci] Introduce LUCI versions of Linux desktop platform tests (flutter/packages#4223) 2023-07-14 43054281+camsim99@users.noreply.github.com [camerax] Marks all wrapped classes as immutable (flutter/packages#4451) 2023-07-14 47866232+chunhtai@users.noreply.github.com [go_router] Bumps example go_router version and migrate example code (flutter/packages#4469) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@369ee7e...6889cca 2023-07-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.3 to 2.20.4 (flutter/packages#4490) 2023-07-15 stuartmorgan@google.com [ci] Switch Android unit tests to LUCI (flutter/packages#4406) 2023-07-15 stuartmorgan@google.com [ci] Introduce LUCI versions of Linux desktop platform tests (flutter/packages#4223) 2023-07-14 43054281+camsim99@users.noreply.github.com [camerax] Marks all wrapped classes as immutable (flutter/packages#4451) 2023-07-14 47866232+chunhtai@users.noreply.github.com [go_router] Bumps example go_router version and migrate example code (flutter/packages#4469) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This moves Android unit tests from Cirrus to LUCI. In order to accomplish this:
camera_androidunit tests with 11.Build.VERSION.SDK_INTin unit tests (which was already giving warnings when run with JDK 11) no longer works at all in JDK 12.Part of flutter/flutter#114373