[camerax] Fix CameraInfo cast causing failure in integration test#3558
[camerax] Fix CameraInfo cast causing failure in integration test#3558auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM.
Do we know how a roll broke this?
I'm actually confused about this, but this test started breaking for me late last week after making no changes to anything related (except maybe run the test with the |
|
Also, @stuartmorgan is this going to be able to land or will submit-queue block it? |
|
The |
…utter#3558) [camerax] Fix CameraInfo cast causing failure in integration test
Fixes a cast causing a post-submit failure for the Flutter roll into packages: https://github.com/flutter/packages/runs/12290760669.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).