[flutter_markdown] add AssetManifest.bin to TestAssetBundle#3422
[flutter_markdown] add AssetManifest.bin to TestAssetBundle#3422auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
No version/changelog needed: |
|
I'm afraid to merge since running flutter test output |
|
goldens are only valid on the machine they were generated on, more or less. I wouldn't worry about it |
…3422) [flutter_markdown] add AssetManifest.bin to TestAssetBundle
See #3420 (comment). Fixes a test broken by flutter/flutter#121322.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.