[go_router] Fix Incorrect URL after pop twice#2989
Closed
leehack wants to merge 4 commits intoflutter:mainfrom
Closed
[go_router] Fix Incorrect URL after pop twice#2989leehack wants to merge 4 commits intoflutter:mainfrom
leehack wants to merge 4 commits intoflutter:mainfrom
Conversation
Contributor
|
Thanks for submitting this pr, but we already have a fix waiting for review #2952 |
Author
|
@chunhtai, I'm still wondering if we could merge this as a hotfix since it's pretty small so that we can address the issue quickly while the PR is being reviewed unless it will be merged shortly. I saw the PR is removing the function I modified, so the conflict will also be minimal. What do you think? |
Contributor
|
I think it should be merged shortly |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL doesn't match to the route when it pops twice or more due to the pattern mismatch.
When it pops from
/one/two/three, it goes to/one/two/instead of/one/two.From the next pops, it can't match the pattern due to the
/at the end of the path.With the fix, it just makes sure to match
two/as well.flutter/flutter#117431
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.