[pointer_interceptor] fix integration test#1675
Merged
fluttergithubbot merged 5 commits intoflutter:mainfrom Apr 30, 2022
Merged
[pointer_interceptor] fix integration test#1675fluttergithubbot merged 5 commits intoflutter:mainfrom
fluttergithubbot merged 5 commits intoflutter:mainfrom
Conversation
Member
|
We should have picked this up with our roller, but tests for this package were being skipped. Running tests within the |
|
This pull request is not suitable for automatic merging in its current state.
|
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pointer interceptor test was probing into some implementation details of the web engine. As of flutter/engine#32712, the implementation has changed such that the semantics tree now sits on top of the platform views. This PR fixes the test accordingly.
Bonus: