Check for a null codec in MultiFrameImageStreamCompleter after calling _emitFrame by jason-simmons · Pull Request #165009 · flutter/flutter

jason-simmons · 2025-03-11T20:24:31Z

_emitFrame invokes image listeners. A listener callback could remove all of the MultiFrameImageStreamCompleter's listeners, resulting in a _maybeDispose call that destroys the codec.

Fixes #164944
Fixes #164537

…g _emitFrame _emitFrame invokes image listeners. A listener callback could remove all of the MultiFrameImageStreamCompleter's listeners, resulting in a _maybeDispose call that destroys the codec. Fixes flutter#164944 Fixes flutter#164537

jonahwilliams

LGTM

…r calling _emitFrame (flutter/flutter#165009)

…g _emitFrame (flutter#165009) _emitFrame invokes image listeners. A listener callback could remove all of the MultiFrameImageStreamCompleter's listeners, resulting in a _maybeDispose call that destroys the codec. Fixes flutter#164944 Fixes flutter#164537

jason-simmons requested a review from jonahwilliams March 11, 2025 20:24

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 11, 2025

format

a8160da

jonahwilliams approved these changes Mar 11, 2025

View reviewed changes

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

auto-submit bot added this pull request to the merge queue Mar 12, 2025

Merged via the queue into flutter:master with commit 6316b48 Mar 12, 2025
74 of 75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to 6316b48bca8d (39 revisions) flutter/packages#8861

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

1f33108

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to f0992e09655a (40 revisions) flutter/packages#8862

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

781c2e5

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to c6c518653c39 (56 revisions) flutter/packages#8865

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

11624f2

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to ea4cdcf39e93 (57 revisions) flutter/packages#8866

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

de79bbf

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 884de6185518 (58 revisions) flutter/packages#8867

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

7381a39

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0a937ba4dafc (59 revisions) flutter/packages#8868

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

defd72c

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 627f1d200bac (60 revisions) flutter/packages#8869

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

3a54de6

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0aa0ad160ed2 (61 revisions) flutter/packages#8870

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

3132b2d

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

b3c0ad4

…r calling _emitFrame (flutter/flutter#165009)

This was referenced Mar 13, 2025

Roll Flutter from b16430b2fd57 to c38f0b7aaee3 (63 revisions) flutter/packages#8871

Closed

Roll Flutter from b16430b2fd57 to 208883fe1256 (76 revisions) flutter/packages#8875

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

718bf77

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

bfe6c5f

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

352de81

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

d882d23

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

59dd160

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

4b9dfd8

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

f0e5446

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

909b716

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

d8cdede

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

f4b2585

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

049746f

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

7e460bb

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

7fc1791

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

4be9faa

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

776567d

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

e22351f

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

1151024

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

58493b9

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

5de8b87

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

5d4b8a8

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

0d9f146

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

9ba782b

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

1ae9072

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

facb04a

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

77c47ad

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

3d38e50

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

d330543

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

6ffd4b2

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

e1c1dc3

…r calling _emitFrame (flutter/flutter#165009)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

6316b48 Check for a null codec in MultiFrameImageStreamCompleter afte…

df61a62

…r calling _emitFrame (flutter/flutter#165009)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check for a null codec in MultiFrameImageStreamCompleter after calling _emitFrame#165009

Check for a null codec in MultiFrameImageStreamCompleter after calling _emitFrame#165009
auto-submit[bot] merged 2 commits intoflutter:masterfrom
jason-simmons:bug_164944

jason-simmons commented Mar 11, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jason-simmons commented Mar 11, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants