Platform view devicelab ad banner scroll list real ads by jmagman · Pull Request #145239 · flutter/flutter

jmagman · 2024-03-15T23:05:24Z

Reland #144745, which was reverted due to a the Android app ads not being set up correctly, crashing on launch: #145228

Add the missing com.google.android.gms.ads.APPLICATION_ID meta-data tag to the manifest.

Validated both platform_views_scroll_perf__timeline_summary and platform_views_scroll_perf_impeller__timeline_summary ran locally on an Android emulator.

Successful presubmit runs:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/4/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/4/overview

Original commit message:

This benchmark is to measure the platform view performance improvement.

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue #144339

Fixes #143534
Fixes #143257

…es.dart

jmagman · 2024-03-15T23:07:42Z

.ci.yaml

  # linux motog4 benchmark
  - name: Linux_android platform_views_scroll_perf__timeline_summary
    recipe: devicelab/devicelab_drone
-    presubmit: false


I won't land the presubmit: false changes, I want to validate in presubmit.

jmagman · 2024-03-15T23:08:20Z

dev/benchmarks/platform_views_layout/android/app/src/main/AndroidManifest.xml

+        <!-- Sample AdMob app ID: ca-app-pub-3940256099942544~3347511713 -->
+        <meta-data
+            android:name="com.google.android.gms.ads.APPLICATION_ID"
+            android:value="ca-app-pub-3940256099942544~3347511713" />


This is the only change on top of #145224

jonahwilliams

LGTM

…er/flutter#145239)

flutter/flutter@71606af...7c860dd 2024-03-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from cfbf11d757d1 to 4c420dd2dfd9 (2 revisions) (flutter/flutter#145280) 2024-03-17 ian@hixie.ch Factor out use of "print" in flutter_goldens (flutter/flutter#144846) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd4050334ff3 to cfbf11d757d1 (1 revision) (flutter/flutter#145275) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 618ee6c8ba34 to dd4050334ff3 (1 revision) (flutter/flutter#145270) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4602aa149d8 to 618ee6c8ba34 (1 revision) (flutter/flutter#145266) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 91b9cf24d328 to e4602aa149d8 (1 revision) (flutter/flutter#145259) 2024-03-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland #128236 "Improve build output for all platforms" (#143166)" (flutter/flutter#145261) 2024-03-16 6655696+guidezpl@users.noreply.github.com Reland #128236 "Improve build output for all platforms" (flutter/flutter#143166) 2024-03-16 6655696+guidezpl@users.noreply.github.com Introduce `Split` curve (flutter/flutter#143130) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 120e52b8a1c2 to 91b9cf24d328 (1 revision) (flutter/flutter#145256) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3abc25139959 to 120e52b8a1c2 (1 revision) (flutter/flutter#145254) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f180615e6ac to 3abc25139959 (1 revision) (flutter/flutter#145253) 2024-03-16 magder@google.com Platform view devicelab ad banner scroll list real ads (flutter/flutter#145239) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6ddaa40bf1a6 to 6f180615e6ac (1 revision) (flutter/flutter#145251) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from d46c1fa17dda to 6ddaa40bf1a6 (1 revision) (flutter/flutter#145250) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f15dc1200bc to d46c1fa17dda (2 revisions) (flutter/flutter#145248) 2024-03-16 31859944+LongCatIsLooong@users.noreply.github.com Use a separate `TextPainter` for intrinsics calculation in `RenderEditable` and `RenderParagraph` (flutter/flutter#144577) 2024-03-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2db915c64e6e to 7f15dc1200bc (1 revision) (flutter/flutter#145245) 2024-03-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from ba1115c30381 to 2db915c64e6e (2 revisions) (flutter/flutter#145240) 2024-03-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c2fd5333a5d2 to ba1115c30381 (3 revisions) (flutter/flutter#145237) 2024-03-15 91688203+yusuf-goog@users.noreply.github.com Renaming the virtual device Nexus5 name to Nexus5.gce_x86 (flutter/flutter#145225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er/flutter#145239)

hellohuanlin and others added 20 commits March 15, 2024 11:40

dummy benchmark for ad banner scroll

da55c70

add admob dependency

a34b4ef

add admob test id

03348d1

pod install & use real ads in code

5ac97bb

rename file

4f8de1b

clean up ad banners main

a50f665

CI presubmit trick

7e3418c

do not force GC

be377eb

clean up dart app

fd34fd6

remove caret

8403248

nit

06a0244

remove ci presubmit trick

a9b0bae

run flutter update-packages --force-upgrade

46f468e

remove team

768eed0

revert nit

615eab9

revert pubspec change

4f2f089

rerun checksum

18e5f20

nit

dd357fb

regenerate lock files with dart dev/tools/bin/generate_gradle_lockfil…

1280553

…es.dart

Add ads to AndroidManifest meta-data

4487b75

jmagman self-assigned this Mar 15, 2024

github-actions bot added the f: scrolling Viewports, list views, slivers, etc. label Mar 15, 2024

Run failing test in presubmit

1f78af1

jmagman commented Mar 15, 2024

View reviewed changes

jmagman added 2 commits March 15, 2024 16:08

platform_views_scroll_perf_ad_banners__timeline_summary

3c2ab41

nm platform_views_scroll_perf_ad_banners__timeline_summary

413bde1

jmagman requested review from hellohuanlin and jonahwilliams March 15, 2024 23:17

revert presubmit in .ci.yaml

1203ccd

jonahwilliams approved these changes Mar 15, 2024

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2024

jmagman requested a review from gmackall March 15, 2024 23:20

jmagman added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Mar 15, 2024

auto-submit bot merged commit a2678be into flutter:master Mar 16, 2024

jmagman deleted the ad-android branch March 16, 2024 05:44

engine-flutter-autoroll mentioned this pull request Mar 16, 2024

Roll Flutter from c01d7f069861 to e7baebdce72d (85 revisions) flutter/packages#6343

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024

a2678be Platform view devicelab ad banner scroll list real ads (flutt…

d0e63e1

…er/flutter#145239)

engine-flutter-autoroll mentioned this pull request Mar 16, 2024

Roll Flutter from c01d7f069861 to 16d0731363c3 (86 revisions) flutter/packages#6344

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024

a2678be Platform view devicelab ad banner scroll list real ads (flutt…

3ce8aac

…er/flutter#145239)

engine-flutter-autoroll mentioned this pull request Mar 17, 2024

Roll Flutter from 71606af8d82e to 7c860ddf9705 (21 revisions) flutter/packages#6345

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2024

a2678be Platform view devicelab ad banner scroll list real ads (flutt…

38df0f9

…er/flutter#145239)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

a2678be Platform view devicelab ad banner scroll list real ads (flutt…

3884e7e

…er/flutter#145239)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Platform view devicelab ad banner scroll list real ads#145239

Platform view devicelab ad banner scroll list real ads#145239
auto-submit[bot] merged 24 commits intoflutter:masterfrom
jmagman:ad-android

jmagman commented Mar 15, 2024 •

edited

Loading

Uh oh!

jmagman Mar 15, 2024

Uh oh!

jmagman Mar 15, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jmagman commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

jmagman Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmagman commented Mar 15, 2024 •

edited

Loading