Reland Activate InkSparkle on CanvasKit#144314
Reland Activate InkSparkle on CanvasKit#144314bleroux wants to merge 1 commit intoflutter:masterfrom
Conversation
|
Unfortunately, we're now back to the error message we got some months ago, see #138545 (comment) Looks like this error was just hidden by the one fixed in flutter/engine#49754. |
521b726 to
f459f57
Compare
5c45dfa to
cdc6713
Compare
|
I filed #144597 to make the |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cdc6713 to
abac81b
Compare
a8537ab to
d9c1fd5
Compare
|
Closing this PR for the moment because:
|
Description
This PR activates the M3
InkSparklesplash animation on Android + CanvasKit.This is a reland for #138545 which was reverted due to a Flutter Gallery integration test failure.
The failure which lead to the revert was reproducible as described in #143075.
I'm no more able to reproduce this error locally.
The root issue was probably fixed in flutter/engine#49754.
Related Issue
Fixes #138487
Tests
Updates several existing tests.