This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Skwasm] Respect the debugDisableFallbackFonts flag.#51626
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Mar 22, 2024
Merged
[Skwasm] Respect the debugDisableFallbackFonts flag.#51626auto-submit[bot] merged 2 commits intoflutter:mainfrom
debugDisableFallbackFonts flag.#51626auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
ditman
approved these changes
Mar 22, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM. Lil' non-blocking comments.
| void layout(ui.ParagraphConstraints constraints) { | ||
| paragraphLayout(handle, constraints.width); | ||
| if (!_hasCheckedForMissingCodePoints) { | ||
| if (!debugDisableFontFallbacks && !_hasCheckedForMissingCodePoints) { |
Member
There was a problem hiding this comment.
I find if !(debugDisableFontFallbacks || _hasCheckedForMissingCodePoints) a little bit more legible, but... it's the same.
Co-authored-by: David Iglesias <ditman@gmail.com>
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 22, 2024
flutter/engine@cc8f752...52142e4 2024-03-22 jacksongardner@google.com [Skwasm] Respect the `debugDisableFallbackFonts` flag. (flutter/engine#51626) 2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 6484a450c457 to eb6976fc57cc (1 revision) (flutter/engine#51627) 2024-03-22 jacksongardner@google.com [skwasm] Throw when gradient color stops are invalid in debug mode. (flutter/engine#51624) 2024-03-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AW70sjrQKy2sSXpUA... to _uuBNUJ6KbprCDWmC... (flutter/engine#51625) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from AW70sjrQKy2s to _uuBNUJ6Kbpr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skwasm needs to respect the
debugDisableFallbackFontsflag, which is used by framework tests.