This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Convert chromium wheel delta to physical pixels on macOS#49028
Merged
knopp merged 2 commits intoflutter:mainfrom Dec 18, 2023
Merged
Convert chromium wheel delta to physical pixels on macOS#49028knopp merged 2 commits intoflutter:mainfrom
knopp merged 2 commits intoflutter:mainfrom
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2023
flutter/engine@92d88c7...632103f 2023-12-18 matej.knopp@gmail.com Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200) 2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193) 2023-12-18 barpac02@gmail.com Delete `SemanticsUpdateBuilderNew` and all references and usages (flutter/engine#49139) 2023-12-18 chinmaygarde@google.com Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191) 2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…0350) flutter/engine@92d88c7...632103f 2023-12-18 matej.knopp@gmail.com Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200) 2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193) 2023-12-18 barpac02@gmail.com Delete `SemanticsUpdateBuilderNew` and all references and usages (flutter/engine#49139) 2023-12-18 chinmaygarde@google.com Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002) 2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191) 2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been previously done for Safari in Firefox in #35428. I'm not entirely sure since which release, but for past couple of months Chromium seems to be reporting logical pixels during scroll events as well, which now makes scrolling on Chrome / macOs 2x slower.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.