This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add mechanism for tests to explicitly get a default font.#47483
Closed
kjlubick wants to merge 3 commits intoflutter:mainfrom
Closed
Add mechanism for tests to explicitly get a default font.#47483kjlubick wants to merge 3 commits intoflutter:mainfrom
kjlubick wants to merge 3 commits intoflutter:mainfrom
Conversation
flar
approved these changes
Oct 30, 2023
Contributor
flar
left a comment
There was a problem hiding this comment.
LGTM once the license file is updated as indicated in the task failure message.
jason-simmons
suggested changes
Oct 30, 2023
Member
jason-simmons
left a comment
There was a problem hiding this comment.
I'll create a PR that updates the affected tests to select a specific font.
Contributor
Author
|
#47493 is the better fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #137565 (at least for Linux, which I tested locally. May need another follow-up when we try to revert this Skia change).
If we want a way to get a specific, repeatable font, we can modify this (perhaps by exposing
MakeTypefaceFromName).As Skia continues to migrate its SkFontMgr API away from having a default factory,
third_party/txt/.../platform.hseems like a useful, central place to have these font things go.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.