This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Refactor CapabilitiesGLES into a Capabilties.#46621
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Oct 6, 2023
Merged
[Impeller] Refactor CapabilitiesGLES into a Capabilties.#46621auto-submit[bot] merged 3 commits intoflutter:mainfrom
auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
Contributor
Author
|
Doing this separately so that changes that require other extension checks aren't blocked on the framebuffer fetch PR. |
bdero
approved these changes
Oct 6, 2023
| .SetSupportsDeviceTransientTextures(false) | ||
| .Build(); | ||
| } | ||
| { device_capabilities_ = reactor_->GetProcTable().GetCapabilities(); } |
Contributor
There was a problem hiding this comment.
Nit: No need for these curlys?
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2023
chinmaygarde
reviewed
Oct 6, 2023
| // Create the device capabilities. | ||
| { | ||
| device_capabilities_ = | ||
| CapabilitiesBuilder() |
Contributor
There was a problem hiding this comment.
Can we get rid of CapabilitiesBuilder entirely? All backends should follow the pattern of having a custom capabilities subclass.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 6, 2023
flutter/engine@1bb228d...eb5d5c6 2023-10-06 jonahwilliams@google.com [Impeller] Ensure known geometry has simple bounds computation. (flutter/engine#46623) 2023-10-06 jonahwilliams@google.com [Impeller] Refactor CapabilitiesGLES into a Capabilties. (flutter/engine#46621) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…6094) flutter/engine@1bb228d...eb5d5c6 2023-10-06 jonahwilliams@google.com [Impeller] Ensure known geometry has simple bounds computation. (flutter/engine#46623) 2023-10-06 jonahwilliams@google.com [Impeller] Refactor CapabilitiesGLES into a Capabilties. (flutter/engine#46621) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
From #46585 For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #46585
For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.