This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] [web] Fix HashUrlStrategy.addPopStateListener#41459
Merged
itsjustkevin merged 1 commit intoflutter:flutter-3.10-candidate.1from Apr 25, 2023
Merged
[CP] [web] Fix HashUrlStrategy.addPopStateListener#41459itsjustkevin merged 1 commit intoflutter:flutter-3.10-candidate.1from
itsjustkevin merged 1 commit intoflutter:flutter-3.10-candidate.1from
Conversation
During a JS-interop refactor, we introduced a small bug in the `addPopStateListener` method of the `HashUrlStrategy` object (web). This wasn't caught before because the existing tests were mocking the refactored code. ## Issues Fixes: flutter/flutter#125228 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
flutter-dashboard
bot
added
the
platform-web
itsjustkevin
approved these changes
Apr 25, 2023
Contributor
|
@CaseyHillers im assuming |
Contributor
Correct, I can confirm. We should CP in #41210 |
Contributor
|
Will cherry-pick in with the engine PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks: 8d9f17e
Fixes flutter/flutter#125317
During a JS-interop refactor, we introduced a small bug in the
addPopStateListenermethod of theHashUrlStrategyobject (web).This wasn't caught before because the existing tests were mocking the refactored code.
Issues
Fixes: flutter/flutter#125228
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.