This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] Fix Path tests#37635
Merged
harryterkelsen merged 1 commit intoflutter:mainfrom Nov 18, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
platform-web
yjbanov
approved these changes
Nov 16, 2022
harryterkelsen
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2022
* 5471734 [macOS] Cleanup unnecessary references to Metal (flutter/engine#37733) * 39f5465 Fix CanvasKit path tests (flutter/engine#37635)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5618) * 5471734 [macOS] Cleanup unnecessary references to Metal (flutter/engine#37733) * 39f5465 Fix CanvasKit path tests (flutter/engine#37635)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5618) * 5471734 [macOS] Cleanup unnecessary references to Metal (flutter/engine#37733) * 39f5465 Fix CanvasKit path tests (flutter/engine#37635)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Path tests that regressed as a result of test results not being reported properly.
The test for checking that
metrics.toList()can be called multiple times is invalid because according to the docs: "This iterable does not memoize. Callers who need to traverse the list multiple times, or who need to randomly access elements of the list, should use toList on this object."Partially addresses flutter/flutter#115327
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.