This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Trackpad gesture PointerData types#31402
Merged
dkwingsmt merged 1 commit intoflutter:mainfrom Feb 11, 2022
Merged
Conversation
This reverts commit 90effff.
goderbauer
approved these changes
Feb 11, 2022
Member
goderbauer
left a comment
There was a problem hiding this comment.
RSLGTM assuming no changes since the previous PR to this code
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR was #28571
Reverted in #31375
Should be acceptable now thanks to flutter/flutter#98202
This commit adds support to the engine core for encoding trackpad gestures for to the framework. This covers zoom, rotate, and pan gestures. The changes to send trackpad gestures from each platform will come in follow-up PRs.
PointerChange:panZoomStart,panZoomUpdate,panZoomEndPointerDatato handle two-finger trackpad gesture fields (panX,panY,scale,rotation)Design Document
Framework PR: flutter/flutter#89944
Addresses flutter/flutter#23604
Pre-launch Checklist
writing and running engine tests.
///).