Remove dead localization code from the iOS embedder#27472
Remove dead localization code from the iOS embedder#27472fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
The code is dead because flutter#17755 has been reverted by flutter#19136, although flutter#18519 has not been properly reverted.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@GaryQian Since you were the author of the reverted PR, can you please take a look and sign off on this? |
|
Is this still on your radar Gary? |
GaryQian
left a comment
There was a problem hiding this comment.
LGTM, thanks for the catch!
The code is dead because #17755 has been reverted by #19136,
although #18519 has not been properly reverted.
cc @GaryQian
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.