[Android text input] fix android autofill on focused text field by LongCatIsLooong · Pull Request #24463 · flutter/engine

LongCatIsLooong · 2021-02-17T22:05:40Z

Fixes flutter/flutter#75833

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.
The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

LGTM 👍

justinmc · 2021-02-17T22:28:01Z

shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java

  }

+  // Called by the text input channel to update the text input plugin with the
+  // latest TextEditState from the framework.


Nit: TextEditState => TextEditingState

The class that this method takes as a parameter is called TextEditState.

justinmc · 2021-02-17T22:33:50Z

shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

+
+    // The autofill value of the focused field is sent via updateEditingState.
+    verify(textInputChannel, times(1))
+        .updateEditingState(anyInt(), eq("focused field"), eq(13), eq(13), eq(-1), eq(-1));


Where do the 13s come from?

"focused field".length == 13, the autofill implementation puts the caret at the end.

…ld (flutter/engine#24463)

…ter#24463)

LongCatIsLooong added 2 commits February 17, 2021 13:56

fix android autofill on focused field

3081fc6

code comments

323300c

LongCatIsLooong requested review from GaryQian and justinmc February 17, 2021 22:05

flutter-dashboard bot added the platform-android label Feb 17, 2021

google-cla bot added the cla: yes label Feb 17, 2021

justinmc approved these changes Feb 17, 2021

View reviewed changes

LongCatIsLooong added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 18, 2021

fluttergithubbot merged commit e31cb0d into flutter:master Feb 18, 2021

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to e31cb0d05bb3 (35 revisions) flutter/flutter#76285

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

5fe99d3

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to 735a244557a3 (37 revisions) flutter/flutter#76289

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

54144a5

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to 2b9951d88f6c (38 revisions) flutter/flutter#76295

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

6e70d7b

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to 71ed1f9b59f4 (39 revisions) flutter/flutter#76298

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

f011a7d

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to a8d73b3dbdea (40 revisions) flutter/flutter#76304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

46a48b7

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to eb18af907eba (42 revisions) flutter/flutter#76307

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

94a700a

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to ff9fc6c4ffd1 (43 revisions) flutter/flutter#76314

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

a6d4c22

…ld (flutter/engine#24463)

LongCatIsLooong deleted the fix-android-autofill branch February 18, 2021 17:49

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to 8c81ce6250bd (44 revisions) flutter/flutter#76320

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

202e649

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to 249ce2893338 (46 revisions) flutter/flutter#76324

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

773bf17

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to 4956ad900fc1 (47 revisions) flutter/flutter#76329

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

3fc982d

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 18, 2021

Roll Engine from 6993cb229b99 to a6d9a1814efd (50 revisions) flutter/flutter#76336

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

5ef1fa6

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 19, 2021

Roll Engine from 6993cb229b99 to cd6c9bcb8f92 (56 revisions) flutter/flutter#76350

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

54afc7a

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 19, 2021

Roll Engine from 6993cb229b99 to cd6c9bcb8f92 (56 revisions) flutter/flutter#76351

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

93f45e3

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 19, 2021

Roll Engine from 6993cb229b99 to c217d9d06e4f (60 revisions) flutter/flutter#76352

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

b622098

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 19, 2021

Roll Engine from 6993cb229b99 to 76b9351947fa (63 revisions) flutter/flutter#76363

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

9146858

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 19, 2021

Roll Engine from 6993cb229b99 to 474142ff7c4e (71 revisions) flutter/flutter#76386

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

e71e7d2

…ld (flutter/engine#24463)

engine-flutter-autoroll mentioned this pull request Feb 19, 2021

Roll Engine from 6993cb229b99 to b793775d2a01 (73 revisions) flutter/flutter#76404

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021

e31cb0d [Android text input] fix android autofill on focused text fie…

9779f6a

…ld (flutter/engine#24463)

hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021

[Android text input] fix android autofill on focused text field (flut…

7e41998

…ter#24463)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android text input] fix android autofill on focused text field#24463

[Android text input] fix android autofill on focused text field#24463
fluttergithubbot merged 2 commits intoflutter:masterfrom
LongCatIsLooong:fix-android-autofill

LongCatIsLooong commented Feb 17, 2021

Uh oh!

justinmc left a comment

Uh oh!

justinmc Feb 17, 2021

Uh oh!

LongCatIsLooong Feb 17, 2021

Uh oh!

justinmc Feb 17, 2021

Uh oh!

LongCatIsLooong Feb 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

LongCatIsLooong commented Feb 17, 2021

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants