Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Reland "Remove pipeline in favor of layer tree holder (#18901…#24456

Merged
zanderso merged 1 commit intoflutter:masterfrom
iskakaushik:revert-lth
Feb 17, 2021
Merged

Revert "Reland "Remove pipeline in favor of layer tree holder (#18901…#24456
zanderso merged 1 commit intoflutter:masterfrom
iskakaushik:revert-lth

Conversation

@iskakaushik
Copy link
Contributor

@iskakaushik iskakaushik commented Feb 17, 2021

@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@iskakaushik
Copy link
Contributor Author

iskakaushik commented Feb 17, 2021

cc: @flar , @chinmaygarde seems like it didn't stick this time due to one failing test on linux, where the trace events were getting lost. Checking why, and will try to reland after.

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 17, 2021
@zanderso zanderso merged commit 04afdad into flutter:master Feb 17, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
c47411e 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
0cc6efa 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
d4d0583 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
f4467d5 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
dc0e4b5 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
70cdef2 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
745474c 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
dd394a6 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
18e3fa2 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
46a60db 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
3fa454e 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
5e85b79 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
dadf76f 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
60f702a 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
a6c41b2 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
ef3f4e2 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
8abf4ac 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
83412fb 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
c463ae0 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
4e9f1a3 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
2706938 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
33d509e 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
ee6384c 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
04afdad Revert "Reland "Remove pipeline in favor of layer tree holder (…
460e62f 
…flutter#18901)" (flutter#24387)" (flutter/engine#24456)
iskakaushik added a commit to iskakaushik/engine that referenced this pull request Mar 11, 2021
@iskakaushik
Revert "Revert "Reland "Remove pipeline in favor of layer tree holder (…
3d9b581 
…flutter#18901)" (flutter#24387)" (flutter#24456)"

This reverts commit 04afdad.
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@iskakaushik @hjfreyer
Revert "Reland "Remove pipeline in favor of layer tree holder (flutte…
8470ec9 
…r#18901)" (flutter#24387)" (flutter#24456)

This reverts commit f3fe33b.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iskakaushik @zanderso