Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix right click issue when dragging#24447

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
mdebbar:fix_drag_right_click
Feb 17, 2021
Merged

[web] Fix right click issue when dragging#24447
fluttergithubbot merged 2 commits intoflutter:masterfrom
mdebbar:fix_drag_right_click

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Feb 17, 2021

The easiest way to explain this PR is to show the sequence of events from LMB (left mouse button), RMB (right mouse button), and what we send to Flutter.

Here's what we used to do:

     LMB:   down-------------------up
     RMB:              down------------------up
 Flutter:   down-------move--------up        up!

After this PR, we will be doing:

     LMB:   down-------------------up
     RMB:              down------------------up
 Flutter:   down-------move-------move-------up

Fixes flutter/flutter#75280

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Feb 17, 2021
@mdebbar mdebbar requested review from dkwingsmt and ferhatb February 17, 2021 01:32
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
dkwingsmt
dkwingsmt approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar mentioned this pull request Feb 17, 2021
Closed
@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 17, 2021
@fluttergithubbot fluttergithubbot merged commit 7d7b645 into flutter:master Feb 17, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
f249643
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
8dc80dd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
447b6a2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
5aa1131
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
8f9882c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
b193836
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
3d7db02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
2ace64a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
167f9f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
5b1df4e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
0cd47b4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
1ab6ab1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
ed3ad41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
92d329f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
1a4cf28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
50a80cf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
be915fe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
070a3cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
22ee5e1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
55cd9a6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
3f884ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
4a72d13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
1ec76ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
7d7b645 [web] Fix right click issue when dragging (flutter/engine#24447)
8abda89
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@mdebbar @hjfreyer
[web] Fix right click issue when dragging (flutter#24447)
8032bb7
christopherfujino added a commit that referenced this pull request Mar 31, 2021
@christopherfujino @mdebbar
[flutter_releases] Flutter Stable 2.0.4 Engine Cherrypicks (#25341)
2dce470 
* [web] Fix right click issue when dragging (#24447)
* [web] Fix placeholder-only paragraphs (#24572)
* [web] Reland: Fix painting of last placeholder in paragraph (#24905)

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
@mdebbar mdebbar deleted the fix_drag_right_click branch April 15, 2021 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ferhatb ferhatb Awaiting requested review from ferhatb

1 more reviewer

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web]: Dragging the "draggable" widget causes widget to freeze in the overlay layer

3 participants

@mdebbar @dkwingsmt @fluttergithubbot