This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove unnecessary buffer collection image constraints.#24347
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Feb 11, 2021
dreveman:fix-sysmem-use
Merged
Remove unnecessary buffer collection image constraints.#24347fluttergithubbot merged 2 commits intoflutter:masterfrom dreveman:fix-sysmem-use
fluttergithubbot merged 2 commits intoflutter:masterfrom
dreveman:fix-sysmem-use
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
added 2 commits
February 11, 2021 13:12
These constraints are not needed and result in usage of images with linear layout. That's a significant performance regression on most devices, and also not guaranteed to work as color attachments. Also, use GetBufferCollectionPropertiesFUCHSIA to improve correctness of memory import.
arbreng
approved these changes
Feb 11, 2021
Contributor
|
Verified Fuchsia workstation.x64 works well after applying the flutter change. |
Contributor
|
I've filed flake reports for the failing presubmits and restarted them. |
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 12, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constraints are not needed and result in usage of
images with linear layout. That's a significant
performance regression on most devices, and also not
guaranteed to work as color attachments.
Also, use GetBufferCollectionPropertiesFUCHSIA to improve
correctness of memory import.