Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Remove the global engine entry timestamp"#18256

Closed
mehmetf wants to merge 1 commit intomasterfrom
revert-18182-engine_enter_timestamp
Closed

Revert "Remove the global engine entry timestamp"#18256
mehmetf wants to merge 1 commit intomasterfrom
revert-18182-engine_enter_timestamp

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented May 9, 2020

Reverts #18182

Detailed discussion around g3 test failures are in the roller's chat room.

@auto-assign auto-assign bot requested a review from liyuqian May 9, 2020 17:30
@mehmetf mehmetf requested a review from jason-simmons May 9, 2020 17:43
@mehmetf
Copy link
Contributor Author

mehmetf commented May 9, 2020

I verified that a revert fixes the g3 tests.

@jason-simmons
Copy link
Member

jason-simmons commented May 9, 2020

The bug is happening because I accidentally removed the call to initConfig here:
88b9d42#diff-8e0c9afcddc7151854497b73e0484fccL117

Will send a PR to fix this now.

@mehmetf
Copy link
Contributor Author

mehmetf commented May 9, 2020

Jason is forward fixing this.

@mehmetf mehmetf closed this May 9, 2020
@cbracken cbracken deleted the revert-18182-engine_enter_timestamp branch June 24, 2020 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants